From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: Re: Move softcursor out of fbdev to fbcon Date: Thu, 28 Jul 2005 10:12:22 +0800 Message-ID: <42E83F06.3000508@gmail.com> References: <42E73C6E.1090205@gmail.com> <9e473391050727073269e33a44@mail.gmail.com> <42E7D77F.6020005@gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1Dxxsv-0005jP-ER for linux-fbdev-devel@lists.sourceforge.net; Wed, 27 Jul 2005 19:12:33 -0700 Received: from wproxy.gmail.com ([64.233.184.197]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1Dxxsv-0004jH-3Z for linux-fbdev-devel@lists.sourceforge.net; Wed, 27 Jul 2005 19:12:33 -0700 Received: by wproxy.gmail.com with SMTP id i3so322118wra for ; Wed, 27 Jul 2005 19:12:26 -0700 (PDT) In-Reply-To: Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: James Simmons Cc: Jon Smirl , Linux Fbdev development list James Simmons wrote: >>>> And the next step is to eliminate all fbcon-specific fields from >>>> fb_info to another structure, such as fb_imageblit, fb_fillrect, >>>> fb_cursor, fb_copyarea. We'll have a smaller kernel size for >>>> if fbcon is not enabled. > > Yipes!!! That will be really hard for hardware accelerated drivers. You > have to make fbdv drivers be aware of when fbcon is loaded. Then check to > see if the device maps to a range of VCs. Then register with the fbcon > layer. Really nasty. More bloat in the long run. You're making it more complicated than it sounds. As an initial step, fields in struct fb_info that are fbcon-specific are placed in another struct, say struct fbcon_info. In register_framebuffer, both fb_info and fbcon_info are registered. If CONFIG_FRAMEBUFFER_CONSOLE = n, struct fbcon_info will either be null or just end up containing NULL/dummy entries. The end result will be a smaller and cleaner fb_info. There is really no need for fbdev drivers to detect that fbcon is loaded or not, since they do not know anything about it. They just need to check if CONFIG_FRAMEBUFFER_CONSOLE is set or not. Tony ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf