From: Jeff Garzik <jgarzik@pobox.com>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [git patch] libata fix
Date: Sun, 31 Jul 2005 19:29:23 -0400 [thread overview]
Message-ID: <42ED5ED3.9060209@pobox.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
Please pull from the 'upstream-fixes' branch of
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
to obtain the damnable-annoying[1] fix described in the attached
diffstat/changelog/patch.
Jeff
[1] the option is truly a boolean, that enables or disables a menu (not
any code). But it won't work as a boolean apparently :/ Roman doesn't
have any better suggestions, so oh well.
[-- Attachment #2: libata-dev.txt --]
[-- Type: text/plain, Size: 1509 bytes --]
drivers/scsi/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
commit faa725332f39329288f52b7f872ffda866ba5b09
Author: Adrian Bunk <bunk@stusta.de>
Date: Wed Jul 27 01:06:35 2005 -0700
[PATCH] SCSI_SATA has to be a tristate
SCSI=m must disallow static drivers.
The problem is that all the SATA drivers depend on SCSI_SATA.
With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA
drivers with unwanted effects, e.g.:
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y
-> SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked
into the kernel
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y, SCSI_SATA_AHCI=m
-> SCSI_ATA_ADMA and libata are built statically but
scsi/built-in.o is not linked into the kernel,
SCSI_SATA_AHCI is built modular (unresolved symbols due to missing
libata)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -424,7 +424,7 @@ config SCSI_IN2000
source "drivers/scsi/megaraid/Kconfig.megaraid"
config SCSI_SATA
- bool "Serial ATA (SATA) support"
+ tristate "Serial ATA (SATA) support"
depends on SCSI
help
This driver family supports Serial ATA host controllers
next reply other threads:[~2005-07-31 23:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-31 23:29 Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-16 10:03 [git patch] libata fix Jeff Garzik
2005-12-24 15:13 Jeff Garzik
2006-03-13 0:29 Jeff Garzik
2006-04-12 22:15 Jeff Garzik
2006-06-12 14:26 Jeff Garzik
2006-09-25 19:35 Jeff Garzik
2006-09-25 20:27 ` Alan Cox
2006-09-25 20:29 ` Jeff Garzik
2006-09-25 20:30 ` Alan Cox
2006-09-25 20:08 ` Jeff Garzik
2007-06-04 20:54 Jeff Garzik
2007-10-02 17:17 Jeff Garzik
2008-05-09 20:59 Jeff Garzik
2008-11-14 23:56 Jeff Garzik
2008-11-15 20:30 ` Alan Cox
2009-11-20 11:44 Jeff Garzik
2009-12-07 16:51 Jeff Garzik
2010-01-21 4:29 Jeff Garzik
2010-03-29 20:22 Jeff Garzik
2010-09-28 19:16 Jeff Garzik
2010-11-19 19:19 Jeff Garzik
2011-05-14 18:55 Jeff Garzik
2011-06-10 1:59 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ED5ED3.9060209@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.