All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: Otto Meier <gf435@gmx.net>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: Driver for sata adapter promise sata300 tx4
Date: Mon, 01 Aug 2005 17:16:31 +0100	[thread overview]
Message-ID: <42EE4ADF.4080502@gentoo.org> (raw)
In-Reply-To: <42EE3FB8.10008@gmx.net>

Otto Meier wrote:
> My question is also are these features (NCQ/TCQ) and the heigher 
> datarate be supported by this
> modification? or is only the basic feature set of sata 150 TX4 supported?

NCQ support is under development. Search the archives for Jens Axboe's recent 
patches to support this. I don't know about TCQ.

> Here is the patch:
> 
> --- linux/drivers/scsi/sata_promise.c.orig 2005-08-01 17:09:48.474824778 
> +0200
> +++ linux/drivers/scsi/sata_promise.c 2005-07-31 12:57:06.415979512 +0200

Your patch will not apply because it is linewrapped. You also need to submit 
it in a mail of its own to the relevent lists and maintainer, with your 
sign-off  (see Documentation/SubmittingPatches)

> I just saw the patches of  Luke Kosewski regarding the SATA150 TX4 
> antipating
> them it might be right to modify the patch to
> 
> + { PCI_VENDOR_ID_PROMISE, 0x3d17, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> + board_40518 },

It won't compile like this because board_40518 is not a valid identifier. I 
also think it doesn't really matter as it looks like these identifier codes 
have lost their numerical meanings, and now just signify:

board_2037x - 2 port SATA, maybe with an extra PATA port
board_20319 - 4 port SATA
board_20619 - 4 port PATA

Daniel

  reply	other threads:[~2005-08-01 16:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-01  9:19 Driver for sata adapter promise sata300 tx4 Otto Meier
2005-08-01 14:43 ` Daniel Drake
2005-08-01 15:12   ` Otto Meier
2005-08-01 15:28   ` Otto Meier
2005-08-01 16:16     ` Daniel Drake [this message]
2005-08-01 20:17       ` Jens Axboe
2005-08-01 20:30         ` Jeff Garzik
2005-08-01 20:35           ` Jens Axboe
2005-08-02  8:18             ` Otto Meier
2005-08-01 20:32         ` Jens Axboe
2005-08-01 20:36           ` Jeff Garzik
2005-08-01 20:42             ` Jens Axboe
2005-08-01 20:49               ` Jeff Garzik
2005-08-02  6:48                 ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2005-08-01 14:14 Otto Meier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42EE4ADF.4080502@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=gf435@gmx.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.