Re: Crash in ide_do_request() on card removal

[Steven Scholz <steven.scholz@imc-berlin.de>]

Jens Axboe wrote:

> That's not quite true, q is not invalid after this call. It will only be
> invalid when it is freed (which doesn't happen from here but rather from
> the blk_cleanup_queue() call when the reference count drops to 0).
> 
> This is still not perfect, but a lot better. Does it work for you?
> 
> --- linux-2.6.12/drivers/ide/ide-disk.c~	2005-08-02 12:48:16.000000000 +0200
> +++ linux-2.6.12/drivers/ide/ide-disk.c	2005-08-02 12:48:32.000000000 +0200
> @@ -1054,6 +1054,7 @@
>  	drive->driver_data = NULL;
>  	drive->devfs_name[0] = '\0';
>  	g->private_data = NULL;
> +	g->disk = NULL;
>  	put_disk(g);
>  	kfree(idkp);
>  }

No.
drivers/ide/ide-disk.c: In function `ide_disk_release':
drivers/ide/ide-disk.c:1057: error: structure has no member named `disk'

--
Steven




-- 
Steven Scholz

imc Measurement & Control               imc Meßsysteme GmbH
Voltastr. 5                             Voltastr. 5
13355 Berlin                            13355 Berlin
Germany                                 Deutschland