All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Anzinger <george@mvista.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Keith Owens <kaos@ocs.com.au>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Re: [PATCH] NMI watch dog notify patch
Date: Tue, 02 Aug 2005 13:26:30 -0700	[thread overview]
Message-ID: <42EFD6F6.4020304@mvista.com> (raw)
In-Reply-To: <42EEA910.5060902@mvista.com>

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

It seems that the subject patch generates a warning (missed it on the 
compile).  Here is a patch to eliminate the warning.
-- 
George Anzinger   george@mvista.com
HRT (High-res-timers):  http://sourceforge.net/projects/high-res-timers/

[-- Attachment #2: fix_notify_die_warn.patch --]
[-- Type: text/plain, Size: 926 bytes --]

Source: MontaVista Software, Inc. George Anzinger<george@mvista.com>
Type: Defect Fix 

Description:
	This patch eliminates the warning generated in die_nmi() when
	calling notify_die() by adding "const" to notify_die()'s
	definition.

Signed-off-by: George Anzinger <george@mvista.com>
	
Index: linux-2.6.13-rc/include/asm-i386/kdebug.h
===================================================================
--- linux-2.6.13-rc.orig/include/asm-i386/kdebug.h
+++ linux-2.6.13-rc/include/asm-i386/kdebug.h
@@ -41,7 +41,7 @@ enum die_val {
 	DIE_PAGE_FAULT,
 };
 
-static inline int notify_die(enum die_val val,char *str,struct pt_regs *regs,long err,int trap, int sig)
+static inline int notify_die(enum die_val val, const char *str,struct pt_regs *regs,long err,int trap, int sig)
 {
 	struct die_args args = { .regs=regs, .str=str, .err=err, .trapnr=trap,.signr=sig };
 	return notifier_call_chain(&i386die_chain, val, &args);

      reply	other threads:[~2005-08-02 20:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-28 20:31 [PATCH] NMI watch dog notify patch George Anzinger
2005-07-28 23:13 ` Andrew Morton
2005-07-28 23:58   ` George Anzinger
2005-07-29  0:12     ` Andrew Morton
2005-07-29  1:50 ` Keith Owens
2005-07-29  4:16   ` George Anzinger
2005-07-29  5:09     ` Keith Owens
2005-07-29  5:14       ` Andrew Morton
2005-07-29 20:55         ` George Anzinger
2005-07-30  3:24           ` Keith Owens
2005-08-01 22:58             ` George Anzinger
2005-08-02 20:26               ` George Anzinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42EFD6F6.4020304@mvista.com \
    --to=george@mvista.com \
    --cc=akpm@osdl.org \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.