From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arun Sharma <arun.sharma@intel.com>
Subject: Re: [PATCH] Broken timer macros breaks VMX
Date: Tue, 02 Aug 2005 14:16:07 -0700
Message-ID: <42EFE297.2040509@intel.com>
References: <20050730045452.D2F2F11AA@huxley.watson.ibm.com> None None
	<mailman.1122700301.23748@unix-os.sc.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <mailman.1122700301.23748@unix-os.sc.intel.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Leendert van Doorn <leendert@watson.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Leendert van Doorn wrote:

> Correcting the MILLISECS() and friends macros to return s_time_t instead
> of ULL fixes this problem. The other changes are just to get rid of
> redundant code and variables.
> 

Thanks, I have an equivalent change in our internal tree. We also 
changed vpit->period and friends to count in s_time_t instead of 
milliseconds, to reduce some math on every tick.

Now that your patch is already upstream, I've rebased our remaining 
changes against your patch.

I'm working to make our internal tree visible to everyone so that if you 
run into such issues, you can check if a pending commit has already 
fixed it.

	-Arun