Re: [PATCH] aic79xx: fix up transport settings

[Hannes Reinecke <hare@suse.de>]

James Bottomley wrote:
> There's a slight problem in the way you've done the transport
> parameters; reading from the variables actually produces the current
> settings, not the ones you just set (and there's usually a lag because
> devices don't renegotiate until the next command goes over the bus).  If
> you set the bit immediately, you get into the situation where the
> transport parameters report something as being set even if the drive
> cannot support it.
> 
Well, as usual you're correct. I wasn't quite sure as to _when_ the
transport class parameter will be set, as they appearently haven't been
set correctly (this was whilst chasing down the ST/DT setting issue).
But yours if of course the correct way of doing things.

> I patched the driver to do it this way and also corrected a panic in the
> proc routines.
> 
THX. Didn't even know there was a proc panic :-).

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html