From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthieu castet Subject: Re: Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend] Date: Thu, 04 Aug 2005 14:38:51 +0200 Message-ID: <42F20C5B.3020506@free.fr> References: <200508020955.54844.bjorn.helgaas@hp.com> <200508030920.13450.bjorn.helgaas@hp.com> <42F1343B.70707@free.fr> <200508031541.53777.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200508031541.53777.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Bjorn Helgaas Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Shaohua Li , Adam Belay , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-acpi@vger.kernel.org Hi, Bjorn Helgaas wrote: > On Wednesday 03 August 2005 3:16 pm, matthieu castet wrote: > >>Bjorn Helgaas wrote: >> > drivers/char/hpet.c >> > This probably should be converted to PNP. I'll >> > look into doing this. >>IIRC, I am not sure that the pnp layer was able to pass the 64 bits >>memory adress for hpet correctly. But it would be nice if it works. > > > You're right, this was broken. But I've been pushing a PNPACPI > patch to fix this. > > Yes but is ACPI_RSTYPE_ADDRESS64 possible on 32 bit machine ? In this case your patch won't work as res->mem_resource[i].start and res->mem_resource[i].end are unsigned long, and 64 bit value won't fit. Matthieu ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262512AbVHDMkE (ORCPT ); Thu, 4 Aug 2005 08:40:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262505AbVHDMiz (ORCPT ); Thu, 4 Aug 2005 08:38:55 -0400 Received: from postfix3-1.free.fr ([213.228.0.44]:35984 "EHLO postfix3-1.free.fr") by vger.kernel.org with ESMTP id S262509AbVHDMiy (ORCPT ); Thu, 4 Aug 2005 08:38:54 -0400 Message-ID: <42F20C5B.3020506@free.fr> Date: Thu, 04 Aug 2005 14:38:51 +0200 From: matthieu castet User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050802 Debian/1.7.10-1 X-Accept-Language: fr-fr, en, en-us MIME-Version: 1.0 To: Bjorn Helgaas CC: acpi-devel@lists.sourceforge.net, Shaohua Li , Adam Belay , linux-kernel@vger.kernel.org Subject: Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend] References: <200508020955.54844.bjorn.helgaas@hp.com> <200508030920.13450.bjorn.helgaas@hp.com> <42F1343B.70707@free.fr> <200508031541.53777.bjorn.helgaas@hp.com> In-Reply-To: <200508031541.53777.bjorn.helgaas@hp.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, Bjorn Helgaas wrote: > On Wednesday 03 August 2005 3:16 pm, matthieu castet wrote: > >>Bjorn Helgaas wrote: >> > drivers/char/hpet.c >> > This probably should be converted to PNP. I'll >> > look into doing this. >>IIRC, I am not sure that the pnp layer was able to pass the 64 bits >>memory adress for hpet correctly. But it would be nice if it works. > > > You're right, this was broken. But I've been pushing a PNPACPI > patch to fix this. > > Yes but is ACPI_RSTYPE_ADDRESS64 possible on 32 bit machine ? In this case your patch won't work as res->mem_resource[i].start and res->mem_resource[i].end are unsigned long, and 64 bit value won't fit. Matthieu