From: Anthony Liguori <aliguori@us.ibm.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] Make xc_console less chatty
Date: Thu, 04 Aug 2005 15:15:12 -0500 [thread overview]
Message-ID: <42F27750.5060500@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
xc_console is probably too chatty about termios failures since ssh
sessions apparently don't have proper term settings.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
[-- Attachment #2: xc_console_chatty.diff --]
[-- Type: text/x-patch, Size: 1151 bytes --]
diff -r 60c4cd9ebaa1 tools/consoled/xc_console.c
--- a/tools/consoled/xc_console.c Wed Aug 3 16:11:32 2005
+++ b/tools/consoled/xc_console.c Thu Aug 4 15:12:57 2005
@@ -78,23 +78,18 @@
struct termios new_term;
if (tcgetattr(fd, old) == -1) {
- perror("tcgetattr() failed");
return;
}
new_term = *old;
cfmakeraw(&new_term);
- if (tcsetattr(fd, TCSAFLUSH, &new_term) == -1) {
- perror("tcsetattr() failed");
- }
+ tcsetattr(fd, TCSAFLUSH, &new_term);
}
static void restore_term(int fd, struct termios *old)
{
- if (tcsetattr(fd, TCSAFLUSH, old) == -1) {
- perror("tcsetattr() failed");
- }
+ tcsetattr(fd, TCSAFLUSH, old);
}
static int console_loop(int xc_handle, domid_t domid, int fd)
@@ -113,7 +108,6 @@
if (errno == EINTR || errno == EAGAIN) {
continue;
}
- perror("select() failed");
return -1;
}
@@ -131,7 +125,6 @@
(errno == EINTR || errno == EAGAIN)) {
continue;
}
- perror("select() failed");
return -1;
}
@@ -151,7 +144,6 @@
(errno == EINTR || errno == EAGAIN)) {
continue;
}
- perror("select() failed");
return -1;
}
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
reply other threads:[~2005-08-04 20:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F27750.5060500@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.