All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Brindle <jbrindle@tresys.com>
To: Colin Walters <walters@verbum.org>
Cc: Daniel J Walsh <dwalsh@redhat.com>, selinux@tycho.nsa.gov
Subject: Re: Red Hat's passwd
Date: Fri, 05 Aug 2005 15:26:12 -0400	[thread overview]
Message-ID: <42F3BD54.9050603@tresys.com> (raw)
In-Reply-To: <1123269706.20237.25.camel@nexus.verbum.private>

Colin Walters wrote:

>On Fri, 2005-08-05 at 15:07 -0400, Joshua Brindle wrote:
>
>  
>
>>Sounds good to me, trivial patch to do this.. Also, I assume you will 
>>change the previous patch for passwd.c to the new function.
>>    
>>
>
>Shouldn't we also remove checkPasswdAccess from the header?  Otherwise
>what's the point?
>
>  
>
no but we need to add the other..

The point is to allow some transition time so that both are available 
until everything is fixed, then we can remove the other without having 
any problems.

--- selinux.h   (revision 920)
+++ selinux.h   (working copy)
@@ -290,6 +290,7 @@

 /* Check a permission in the passwd class.
    Return 0 if granted or -1 otherwise. */
+extern int selinux_check_passwd_access(access_vector_t requested);
 extern int checkPasswdAccess(access_vector_t requested);

 /* Set the path to the selinuxfs mount point explicitly.

>I should note this approach addresses the consistency and namespacing
>from the developer point of view, but doesn't address possible symbol
>collisions.  Possibly that could wait until a soname bump, just thought
>I'd point it out.
>  
>


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2005-08-05 19:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-05 16:14 Red Hat's passwd Joshua Brindle
2005-08-05 17:12 ` Colin Walters
2005-08-05 18:16   ` Joshua Brindle
2005-08-05 18:38     ` Colin Walters
2005-08-05 18:38     ` Daniel J Walsh
2005-08-05 19:07       ` Joshua Brindle
2005-08-05 19:21         ` Colin Walters
2005-08-05 19:26           ` Joshua Brindle [this message]
2005-08-11 15:00         ` Stephen Smalley
2005-08-11 15:52           ` Joshua Brindle
2005-08-13 10:23             ` Daniel J Walsh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42F3BD54.9050603@tresys.com \
    --to=jbrindle@tresys.com \
    --cc=dwalsh@redhat.com \
    --cc=selinux@tycho.nsa.gov \
    --cc=walters@verbum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.