From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: Re: Re: [PATCH] mach64 atari patch Date: Tue, 09 Aug 2005 09:08:09 +0800 Message-ID: <42F801F9.9090200@gmail.com> References: <20050807094618.0cc4cadc.akpm@osdl.org> <42F699DC.20103@gmail.com> <42F8000A.2040605@gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1E2fgW-0006Y0-Li for linux-fbdev-devel@lists.sourceforge.net; Tue, 09 Aug 2005 18:47:12 -0700 Received: from externalmx-1.sourceforge.net ([12.152.184.25]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1E2f1x-0005es-7L for linux-fbdev-devel@lists.sourceforge.net; Tue, 09 Aug 2005 18:05:44 -0700 Received: from wproxy.gmail.com ([64.233.184.193]) by externalmx-1.sourceforge.net with esmtp (Exim 4.41) id 1E2PvE-0000io-3k for linux-fbdev-devel@lists.sourceforge.net; Tue, 09 Aug 2005 01:57:20 -0700 Received: by wproxy.gmail.com with SMTP id i21so930786wra for ; Tue, 09 Aug 2005 01:57:13 -0700 (PDT) In-Reply-To: <42F8000A.2040605@gmail.com> Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: "Antonino A. Daplas" Cc: James Simmons , linux-fbdev-devel@lists.sourceforge.net, Geert Uytterhoeven , "Antonino A. Daplas" , Andrew Morton Antonino A. Daplas wrote: > James Simmons wrote: >>> Please, my patch (based from Jon's) is huge because it's removing > >>> 200 lines >>> and it's moving softcursor.c from drivers/video to >>> drivers/video/console where >>> it belongs. But it is _not_ intrusive. In fact, the majority of the >>> patch consists >>> of a single logical change which removes the line below from each >>> driver >>> >>> - .fb_cursor = softcursor; >>> >>> and removes the line below from drivers/video/Kconfig. >>> >>> - select FB_SOFT_CURSOR >>> >>> Our proposal aims to make complex code simpler and big code smaller. >>> Your patch, >>> on the other hand, although small, introduces another flag >>> FB_HWCURSOR_SOFTCURSOR, >>> which is redundant, and adds yet another level of complexity to an >>> already too >>> complex code. >> >> I ask you the same question as Jon. Currently several fbdev drivers >> have a optional flag to turn on and off the hardware cursor. Should >> this functionality >> be removed and force all fbdev drivers to always have the hardware >> cursor avaiable. Thus leaving fbcon to control when to use the >> hardware cursor or the software cursor. It all comes down to who >> controls when the hardware driver will use the hardware cursor. As >> noted several drivers have such a flag. You would have to strip that >> flag out of the drivers as well. >> >> . >> > BTW, the only drivers that have working hardware cursor support are > rivafb, intelfb, > nvidiafb, and i810fb. Except for intelfb, I wrote all of them, if not > the driver, the > hardware cursor support. And intelfb's cursor support was based on > i810fb. Erratum: Mach64 also has hardware cursor support, which looks like is working. So I take the above statement back. Tony ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf