From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrey Volkov Subject: Re: cursor maddnes and a solution Date: Wed, 10 Aug 2005 19:37:57 +0400 Message-ID: <42FA1F55.5010801@varma-el.com> References: <42F99B5E.1070309@gmail.com> <9e4733910508092358360f8bc8@mail.gmail.com> <42F9B1C3.2030201@gmail.com> <9e473391050810062531d77aa7@mail.gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1E2sem-0004h3-Ca for linux-fbdev-devel@lists.sourceforge.net; Wed, 10 Aug 2005 08:38:16 -0700 Received: from [195.144.244.147] (helo=amanaus.varma-el.com) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1E2sek-0001JQ-S9 for linux-fbdev-devel@lists.sourceforge.net; Wed, 10 Aug 2005 08:38:16 -0700 In-Reply-To: <9e473391050810062531d77aa7@mail.gmail.com> Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: linux-fbdev-devel@lists.sourceforge.net Cc: "Antonino A. Daplas" , jonsmirl@gmail.com, James Simmons Jon Smirl wrote: > On 8/10/05, Antonino A. Daplas wrote: > >>struct fb_cursor_ops { >> int (*cursor_move)(int x, int y); >> int (*cursor_show)(int show); >> int (*cursor_load_image)(u32 *image, int width, int height); >> int (*cursor_load_color)(struct fb_cmap *cmap); >> int (*cursor_set_size)(int width, int height); >> int (*cursor_capabilities)(int set, int caps); >>}; > > > Doen't fb already support an image format with embedded color map? Can > we use it and merge: > >> int (*cursor_load_image)(u32 *image, int width, int height); >> int (*cursor_load_color)(struct fb_cmap *cmap); > > > The size can also be computed from the image so the size call can be eliminated. > You are omit hwd cursor size problem - very few (possible no one) graphics chips could support cursor with any size. Usually they support 32x32/64x64 pixels cursors only. For kernel fb its have not meaning, 'cause we always could fallback to the soft_cursor (in the fbcon or directly in a driver), BUT what to do with such crazy user who will wish to use, ex. 100x100 pix cursor in user space? -- Regards Andrey Volkov ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf