All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: dougg@torque.net
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] start stop libata attached SATA disks, take 2
Date: Thu, 11 Aug 2005 00:01:41 -0400	[thread overview]
Message-ID: <42FACDA5.5090908@pobox.com> (raw)
In-Reply-To: <42F4746B.6030303@torque.net>

Douglas Gilbert wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Jeff,
> Here is another (more successful) attempt at that patch.
> 
> ChangeLog:
>   - adds minimal START STOP UNIT SCSI command functionality
>     to libata (follows sat-r05 apart from the IMMED bit).
>   - implements the TEST UNIT READY SCSI command as indicated
>     by sat-r05.

> Signed-off-by: Douglas Gilbert <dougg@torque.net>

Looks pretty decent, however...

Can you please resend as two patches:

#1: implement START STOP UNIT
#2: implement TEST UNIT READY

I need to think about TUR a bit more.  Separating into two patches would 
allow me to apply SSU patch to upstream immediately, while applying the 
TUR feature to libata-dev.git respository, queueing it for further 
review and eventual upstream merge.

	Jeff




      reply	other threads:[~2005-08-11  4:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-06  8:27 [PATCH] start stop libata attached SATA disks, take 2 Douglas Gilbert
2005-08-11  4:01 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42FACDA5.5090908@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=dougg@torque.net \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.