From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: tasklist_lock abuse in ipt{,6}owner Date: Thu, 11 Aug 2005 14:29:14 +0200 Message-ID: <42FB449A.7030709@trash.net> References: <20050809211249.GA29430@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org Return-path: To: Christoph Hellwig In-Reply-To: <20050809211249.GA29430@lst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Christoph Hellwig wrote: > Folks, could you please take a look at getting rid of that match_pid > crap? We need to get rid of the tasklist_lock export to change the > locking scheme in that area, and what netfilter does with it is not > pretty. I'd actually prefer dropping those modules completely, this > kind of inverse lookup from file/socket to process shouldn't be done > anywhere in the kernel. I think its ok to rip out cmd/sid/pid matching, it is broken and can't be fixed anyway. Feel free to send a patch, otherwise I'll take care of it.