From: Martin Wilck <martin.wilck@fujitsu-siemens.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Alexander Nyberg <alexn@telia.com>, linux-kernel@vger.kernel.org
Subject: Re: files_lock deadlock?
Date: Fri, 12 Aug 2005 10:42:44 +0200 [thread overview]
Message-ID: <42FC6104.6070200@fujitsu-siemens.com> (raw)
In-Reply-To: <1123830453.3218.0.camel@laptopd505.fenrus.org>
Arjan van de Ven wrote:
> doing anything with files implies having a defined usercontext really,
> and generally sleeping as well. So think this is quite safe.
Looking closer at this, I'd say that files_lock should be replaced by
locking of the respective lists (struct sb->s_files and struct
tty_struct->tty_files, unless I'm mistaken), and that this locking
should be done with semaphores. Right?
Going through the list of all sb->s_files can be a costly operation; it
may be worthwile to have a per-sb locking mechanism for that.
Martin
--
Martin Wilck Phone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck@Fujitsu-Siemens.com
D-33106 Paderborn http://www.fujitsu-siemens.com/primergy
prev parent reply other threads:[~2005-08-12 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-19 16:45 files_lock deadlock? Martin Wilck
2005-07-19 17:48 ` Jan Engelhardt
2005-07-20 14:32 ` Martin Wilck
2005-07-20 14:47 ` Alexander Nyberg
2005-07-20 15:02 ` Martin Wilck
2005-08-11 17:45 ` Martin Wilck
2005-08-11 17:51 ` Arjan van de Ven
2005-08-12 6:41 ` Martin Wilck
2005-08-12 7:07 ` Arjan van de Ven
2005-08-12 8:42 ` Martin Wilck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FC6104.6070200@fujitsu-siemens.com \
--to=martin.wilck@fujitsu-siemens.com \
--cc=alexn@telia.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.