All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] Fix xm block-destroy
Date: Fri, 12 Aug 2005 15:00:53 -0500	[thread overview]
Message-ID: <42FCFFF5.60306@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

If block-create didn't work, then chances are block-destroy doesn't work 
either right :-)

In this case, XendDomain.py is just calling a function that doesn't 
exist (device_destroy instead of device_delete).

Regards,

Anthony Liguori

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

[-- Attachment #2: xend_block_destroy.diff --]
[-- Type: text/x-patch, Size: 744 bytes --]

# HG changeset patch
# User Anthony Liguori <aliguori@us.ibm.com>
# Node ID 73fccd848200b63230002b2d96df897ab232627a
# Parent  17e1b03d6932fa4eb827d61fd7cb32c04213e421
Types do matter in dictionaries, this fixes xm block-destroy

diff -r 17e1b03d6932 -r 73fccd848200 tools/python/xen/xend/server/controller.py
--- a/tools/python/xen/xend/server/controller.py	Fri Aug 12 19:34:09 2005
+++ b/tools/python/xen/xend/server/controller.py	Fri Aug 12 20:06:15 2005
@@ -325,7 +325,7 @@
         return self.destroyed
 
     def getDevice(self, id, error=False):
-        dev = self.devices.get(id)
+        dev = self.devices.get(int(id))
         if error and not dev:
             raise XendError("invalid device id: " + str(id))
         return dev

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2005-08-12 20:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42FCFFF5.60306@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.