All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
To: xen-devel@lists.xensource.com
Subject: Re: Grant Table Network Issues
Date: Sun, 14 Aug 2005 17:53:36 +0100	[thread overview]
Message-ID: <42FF7710.9090504@blueyonder.co.uk> (raw)
In-Reply-To: <20050814153953.GA5037@vrable.net>

Michael Vrable wrote:
> On Sun, Aug 14, 2005 at 09:29:02AM +0100, Keir Fraser wrote:
>>On 13 Aug 2005, at 19:59, Michael Vrable wrote:
>>
>>>The line causing trouble is "BUG_ON(in_irq())". [...]
>>
>>The only code between irq_exit and kmap_skb_frag on the stack trace is 
>>unmodified Linux code. Assuming that is all correct (and presumably the 
>>same whether we enable grant tables or not) I might guess another 
>>interrupt arrives and the handler corrupts things?
> 
> I discovered the cause of this and other crashes yesterday: when grant
> tables are enabled in the netback driver, net_tx_action() and
> net_tx_action_dealloc() in netback.c each allocate large arrays from the
> kernel's stack ("gnttab_map_grant_ref_t map_ops[MAX_PENDING_REQS]" and
> "gnttab_unmap_grant_ref_t unmap_ops[MAX_PENDING_REQS]").  This results
> in a stack overflow.

Is there no way to make a kernel stack overflow fail fast with an obvious
error, rather than causing other subtle failures?

-- 
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>

      parent reply	other threads:[~2005-08-14 16:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-13 18:59 Grant Table Network Issues Michael Vrable
2005-08-14  8:29 ` Keir Fraser
2005-08-14 15:39   ` Michael Vrable
2005-08-14 15:46     ` Michael Vrable
2005-08-14 15:59       ` Ian Pratt
2005-08-14 16:15         ` Steven Hand
2005-08-14 16:27         ` Michael Vrable
2005-08-14 16:43           ` Michael Vrable
2005-08-14 16:53     ` David Hopwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42FF7710.9090504@blueyonder.co.uk \
    --to=david.nospam.hopwood@blueyonder.co.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.