From: Damien Le Moal <dlemoal@kernel.org>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Niklas Cassel" <cassel@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org,
"Christian A. Ehrhardt" <christian.ehrhardt@codasip.com>,
"Christian A. Ehrhardt" <lk@c--e.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v1 1/8] ata: pata_budda: Use named initializer for zorro_device_id
Date: Wed, 27 May 2026 17:11:59 +0900 [thread overview]
Message-ID: <42a4627a-e4f6-4bbd-89eb-559d1f969053@kernel.org> (raw)
In-Reply-To: <a20f52aeee9dfcacfaea43ff280fa1867878cbbe.1779803053.git.u.kleine-koenig@baylibre.com>
On 5/26/26 11:17 PM, Uwe Kleine-König (The Capable Hub) wrote:
> Using named initializers is more explicit and thus easier to parse for a
> human.
>
> It's also more robust to changes in the struct definition. This robustness
> is relevant for a planned change to struct zorro_device_id that replaces
> .driver_data by an anonymous union.
>
> This change doesn't introduce changes to the compiled zorro_device_id
> array.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Acked-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-05-27 8:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 14:17 [PATCH v1 0/8] zorro: Improve handling of pointers in zorro_device_id::driver_data Uwe Kleine-König (The Capable Hub)
2026-05-26 14:17 ` [PATCH v1 1/8] ata: pata_budda: Use named initializer for zorro_device_id Uwe Kleine-König (The Capable Hub)
2026-05-27 7:42 ` Niklas Cassel
2026-05-27 8:11 ` Damien Le Moal [this message]
2026-05-27 13:15 ` Geert Uytterhoeven
2026-05-26 14:17 ` [PATCH v1 2/8] scsi: " Uwe Kleine-König (The Capable Hub)
2026-05-27 13:15 ` Geert Uytterhoeven
2026-05-26 14:17 ` [PATCH v1 net-next 3/8] net: Use named initializer for zorro_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-05-27 13:16 ` Geert Uytterhoeven
2026-05-26 14:17 ` [PATCH v1 4/8] i2c: icy:pick " Uwe Kleine-König (The Capable Hub)
2026-05-27 13:16 ` Geert Uytterhoeven
2026-05-28 7:48 ` Max Staudt
2026-05-28 22:35 ` Andi Shyti
2026-05-26 14:17 ` [PATCH v1 5/8] video: fm2fb: Use named initializer for zorro_device_id array Uwe Kleine-König (The Capable Hub)
2026-05-27 13:17 ` Geert Uytterhoeven
2026-05-26 14:17 ` [PATCH v1 6/8] zorro: Simplify storing pointers in device id struct Uwe Kleine-König (The Capable Hub)
2026-05-27 13:18 ` Geert Uytterhoeven
2026-05-28 7:50 ` Max Staudt
2026-05-26 14:17 ` [PATCH v1 7/8] scsi: zorro7xx: Make use of struct zorro_device_id::driver_data_ptr Uwe Kleine-König (The Capable Hub)
2026-05-27 13:18 ` Geert Uytterhoeven
2026-05-26 14:17 ` [PATCH v1 8/8] video: cirrusfb: " Uwe Kleine-König (The Capable Hub)
2026-05-27 13:19 ` Geert Uytterhoeven
2026-05-26 15:01 ` [PATCH v1 0/8] zorro: Improve handling of pointers in zorro_device_id::driver_data Geert Uytterhoeven
2026-05-26 16:38 ` Uwe Kleine-König (The Capable Hub)
2026-05-29 1:20 ` patchwork-bot+netdevbpf
2026-06-04 22:44 ` Helge Deller
2026-06-05 11:56 ` Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a4627a-e4f6-4bbd-89eb-559d1f969053@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cassel@kernel.org \
--cc=christian.ehrhardt@codasip.com \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lk@c--e.de \
--cc=martin.petersen@oracle.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.