From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA275313E2B for ; Tue, 3 Mar 2026 06:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.19 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772519998; cv=fail; b=AO0pHlJm+fbRUdoJxmTnN7/cdgBQ6UgRSyO5Gg7Ia5THyAg8aPkvi9Xv5Ek1WMldTm26qcZveoVYvGMrUjJRDTS3oy0bU3s04RfW/Raz/zL+nEUpVoU8jZ2yHRuvjp5dFXrNXfixDbel8QgmUQAFa1hX8U6oXo2E+AjLHampUjY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772519998; c=relaxed/simple; bh=K36mBAUtfymhLf0XsonReLd9ysa8WRh0bdnoyAZCylE=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=LULZIV3tOiOFiozeyZq3UzyiCLPMYpffUYSlEG9T4p/nVk3rkhuInXJ/S/L4bQFinmB53UjGycQGx8n2Ma6+KxnExc4/vo8hqi6mnt/+hN+umAAVLm9uDgbnyUsYREZ+ZVDbK0j7HINYVSdxfm786/IAC/wxSlYjC/DorNaXDus= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=btcDib89; arc=fail smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="btcDib89" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772519997; x=1804055997; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=K36mBAUtfymhLf0XsonReLd9ysa8WRh0bdnoyAZCylE=; b=btcDib899ZXPQl4eW9VkyZKI70fD28Pc+z3XIyHOloYA2Ratsk6acWbs DqgavJArY7gflbYGAcuBG0Gec2bjiWkxDcFMWLWRG8YsqIdZmBw4gC3Wh vFCAGVdH3OR5ZPd0z3MQFFniYCIAXDfaGTj+t2v35fGJoRhzl7GRV5yqN JIapIxrHJWrbKunccf3/S4FjHUbUPpY+yX8bh2I42DBDWuLU/Iov+QMeq Else5mX1i+UW/TnQHs2avJKOwqd3vKUocjAqtO10Yo4jE/2fRDpzFZO2i gcQXDHEte5OryF/r61yiZOkvrx10wtgEE/woc43984fZYOq2kecDARZDk Q==; X-CSE-ConnectionGUID: 34xwRvKaTZiOnsjtSj3jgQ== X-CSE-MsgGUID: UoOS8Am4S52zsZ9FV0OVPQ== X-IronPort-AV: E=McAfee;i="6800,10657,11717"; a="73450528" X-IronPort-AV: E=Sophos;i="6.21,321,1763452800"; d="scan'208";a="73450528" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2026 22:39:57 -0800 X-CSE-ConnectionGUID: bpwwxaokQ9iDZU8ZBkCLEQ== X-CSE-MsgGUID: lBPcBubrRQisuqpu012A3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,321,1763452800"; d="scan'208";a="255772094" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2026 22:39:55 -0800 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 2 Mar 2026 22:39:54 -0800 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Mon, 2 Mar 2026 22:39:54 -0800 Received: from CH1PR05CU001.outbound.protection.outlook.com (52.101.193.29) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 2 Mar 2026 22:39:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V+vQUOSiaEAiRle08piSBaLn9iDTgHU0DFNViqXRPiSbmKIxBxBEU8k4LCWISGws6C4qhBY/gYW7RYYypTsXMKeSgm4k2p9zx1Ch2tSL570FDZjulDF7fCLtRWdEDko5HiaOE76xb3uVzQ0Rdw/YjwdK/WS/2QDu5h7YcGwqrULS9+X7VrF1ddDmE/Yl0EuzC3QWWj2Z1+yd+2PH3r9TZM/0hI5PEFZNu2tnhJsxdtsJ6zkqTPZYG/bB5sTqfxF9ebsZKBzFOQcA1Uesug689OT/Sh91W8uEWsGFStga8s7himqSlsqAMPTnt/10C+e8xo2rtAxWnHQrZroFTYEULQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BkMqD5Q0xHjBPEOaERtXd/tHT3sZUWuD7Tj89ChONcQ=; b=VXhEEf5nPtKDFiKa+POeHl8MvFHNq7XnYkgGV7odbPGJFlMVR+sKS8rvljrewvpRNZVw5hHnYJpInXN+frAZdmF7btrsdVOeNlYDOdooFXU2V5/W1XR7y8YZkyKVcR4S4X+/VZK92w+fGtLe5CqWiobwg9ya0Y+HfXPH/LhmFJ/0ujQG4lQ07+9GAQUEK621+lH2grzYOvMv5upwi+xU1ZwpyG8T+8rOZf12pn5za6xa/moQi8vGGbq5FNDAG5Is6iHvh7Dxwu6NpQbirKRkuzEnsZLPJOh1ToA4p25xGRO18bbAcv0woBin2/h/2Sog0bWizVTq09AomltUy25e6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by IA0PR11MB7329.namprd11.prod.outlook.com (2603:10b6:208:437::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 06:39:45 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%6]) with mapi id 15.20.9654.022; Tue, 3 Mar 2026 06:39:45 +0000 Message-ID: <42a9d7ea-24b7-4aea-956b-d1cdb3748333@intel.com> Date: Tue, 3 Mar 2026 14:39:33 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [RFC][PATCH 5/6] x86/topo: Fix SNC topology mess To: Zhang Rui , Peter Zijlstra CC: Tim Chen , , , , , , , , , , , , , References: <20260226104909.675623579@infradead.org> <20260226105052.737712686@infradead.org> <334d4edb-b8f4-41fb-aa16-6cb7abeaa21d@intel.com> <20260227130130.GD1395266@noisy.programming.kicks-ass.net> <67cfac6fe0495a533fa3204fa01ee07653029e91.camel@linux.intel.com> <20260302164317.GP1282955@noisy.programming.kicks-ass.net> <570f930fcf770119b0edd3453899068876322d91.camel@gmail.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: <570f930fcf770119b0edd3453899068876322d91.camel@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI1PR02CA0034.apcprd02.prod.outlook.com (2603:1096:4:1f6::10) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|IA0PR11MB7329:EE_ X-MS-Office365-Filtering-Correlation-Id: cfe095fd-418a-4af7-af14-08de78efa892 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7416014; X-Microsoft-Antispam-Message-Info: tJPdYH9h6aR2X67JJWQR6MJf+ZcIv0dus61IC3AD8BSmWVnAW6GuLLloLU9haRjGhpZ8cy81/g45udbrosqdXEeLOliv3WxuTqY7fCT/b5xbRSDz0+LaVgRBY9K6LPZLqJ9gUk+ysk97eBOd/jutaUsN7vOOjIwiq6VuJyGoCwcQw76GK17ymm6SCBsnL8fGhvWgw6SC7AEQsUXVg3iIeQIXRKGOm41q935d7efodOVXgvcnriHMD3nEkREAyOKW6nbGIigi3FBdR3ezfPqr4t46oBXzqEnNelo2UQmX3rpZRcsvqHsi/ITBnGsEALiVMcIOceKXDINC5ViXHNwsIz/9pMqSi3+K9ev6hXBK19ekisFMPY0702eVoWHKGrfjHRYBgqe0Jyzo38au9I2m/j18zoNHxJY2mo6vEemh82kqGEvFRbr/aByADGGwdoRSQrgB7C4++jJ/J/J+zNSoDG9niGroFINaUccUvbLT+TbOE8cbvkYrhzrYtjQ+PO7FmTrbr/qywVoQ+9Wgpvjq9DhMVD06qok6ti71JIVBTU1mNYDpziM1OnJGxRQRD4F2uaHt8DEqpapxpjWdwEIIiEJzG2m6H0IFf3xqrcqlHVnj6QAlRRSAYLAu6JT/Oqj5Qa53b5FG1il6+XniSsDzkWb8oxtbJ3+c6jF+xf2h5AHXToO66bEWFQF6usGy3yjBOoxtz0Ced/7azpgoBrHHdOPkgDOdzZS2ovJHDpr9h1k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXpxalk3bVRBRThuUW5WeVl5by9XTnM5ZEM0ajg2MEVTN2xobWJmT1lQYS9k?= =?utf-8?B?NkJ3ZUQ1UTNpR0Q3alRLWXFLUjAwWEhiOHZSbGxVZmw1RDUxTzFJS3NQeWN2?= =?utf-8?B?dlV5aU9LUXJ0dWVLOFN0TGZpUTB1azhBK2ZvR3hZeVpJMVZSdzVtOWRrR0NS?= =?utf-8?B?U0Exc3RiSXVzR0xNblAzZ05RR1RiNTdJT1JmaS9yQmJlbDN0YkdHQzFaQmg4?= =?utf-8?B?VFE3YkJmMXltZHNXS2hkQ2N4ay9YME5lWk9RM3BGWWpJNE04bVFWbFJGY1Bt?= =?utf-8?B?Q1RTVGIwckkzNVZuWXZSYjZsWXc1bURtM1paNUZPWnk5TGhkdDIzQmlyQUhy?= =?utf-8?B?QyszYVhNL2dmR2FKWXZEZDZiL2Voay9ESC9SU3ZPeG9tVEdDOFRDVCtQV0Fl?= =?utf-8?B?YXd6UGZ3bTdyYStjTUNmeXF3Tm14QnZaUzZGMjUxRXZ3MS9McTk1ZXpPZWhB?= =?utf-8?B?TjlQTklHOXMwLy9mb3MrZFFYZzlieksxMkIzcmtSSE5aenNZZXF3ZWVmOW1L?= =?utf-8?B?a2lkeEJtU2NqRUVnbFJPeUVPOUd2UWZtYU5TODBGVTJOWkl0RlJKWW9JZS90?= =?utf-8?B?akJtZ0lEbllNNUdNZ0ZCTW9VZmNpdjZLcWdBTDVoRGtqdjNLeW9SWDQrRmNy?= =?utf-8?B?WFc2M0tZNGlkSG5jajN3cHNyaXlKZVg2bFRJdHA5eHk0RFh0UWJaUktOR2Rr?= =?utf-8?B?QWNsRGtTNjZYQWxWa1NIZFovMnlacFYyVEZSTVhiZ3NmclIvSEQ3N1FzOFpv?= =?utf-8?B?MnlRMVUzZmxrYjF0YzhSWE1nU2pXWmd4eFhqUFFUSlhBbDFqZ2d2RjZNQTI4?= =?utf-8?B?eHZtUnVsVnlKYTdBYisvL0pyT1JVQ2J1UHAzbHRDK3BDWGdmdjFsV0Zwa2FU?= =?utf-8?B?STJoQlpwSFlNN0JXM2dWMnNaNU8wK0w1dzFBcGZjRTNoS1NNTFA0U3hpWmda?= =?utf-8?B?aTJNVHJxMk55RjhSN05DVmdmVlZ1SDN1WVdoUUc5RWU3Y29yWGszM1VZRWh3?= =?utf-8?B?dXJwaGliUkZWWVVrTGlwVjZrM2JFVlZ6Y1FVaEp4bTVxTS8wR1FaL29OeExP?= =?utf-8?B?Q016cmpzeS9nUFJ6dmZnUVNWb3BITmFIVGFFQmJ6b2hTVUsrSVpxS0h1Rmd5?= =?utf-8?B?OEJwUmFNOUZNTlhMeG1FL3lXL1Fqc2tCd0h1WmVJMys1UkVWZkE2SjdDRStK?= =?utf-8?B?V1A0ellBU3RRZmRacW5QaHJoRXVndXVhWXlVWFl2L3FBZHlPSjAxNVVMd0dq?= =?utf-8?B?NllkbWZYaU5BbUl2R2tuVEhiaGl6dkhlbXJtc1M4NjBuYVpIVFRtWWZPWURC?= =?utf-8?B?aUd2ZWg5OUZSQUptUmx1QnhPSUdkdTZkSWdUWFArSndXV21EVk1rNUVEOGhh?= =?utf-8?B?N05VL2w2MVM3SDR4M3QwVHBHOXl3dkFpQVQrUExlaXRTaE93VEVuMW9BK1hX?= =?utf-8?B?dFZmeE9VOVRMOTJTRG52YXBJaGczRGNyWkZZNnJ6QWNyRHNDUTlRUkxlU3BX?= =?utf-8?B?Ui92V010ZXBlMnVsOTZCaTVEM0Q4ZDFjd1VpamRQVlVyRHBBMG40dHBTK0FU?= =?utf-8?B?bFNWdnM2ZDNyVmRXL3B6L0I1YnZieTBpTWZZZVhYeFBWZmVHTGtEYTBZOVpE?= =?utf-8?B?V1RWSXNxa2RQQkNxTE9WVURmNDVSNG1WakI2QnpDNGdsYjNQQStEWFRYVm1J?= =?utf-8?B?d0x0RHVqRmZhbXNvdHZ1YWJKWEZSUmtKdFFwSlRacnd6dDE4YUM2ckUwRC80?= =?utf-8?B?OUJKUE1NUEFWVUtSVTgxZUVCTkFkaitvRUJFSDZQWDl0SnFNb3paZzJaandH?= =?utf-8?B?aUF0MUNUc0MxTVM3ckh0Z0dJejFROWdJb2dOT0FxdzFhRXdYZUZDbTM3Vy9x?= =?utf-8?B?U0JGRXZzUlpoVXc4bzNSdUtMY3gwM2xUUWplV3ZKdWlQSUE5eU1kYWEzSStS?= =?utf-8?B?SFJvK0IzdHQ5YVc5cHk2ZDBXTzAvRDRkNERTdGlmekNDWVg2aGZ5M1BxNWJ3?= =?utf-8?B?aU9CekRMa09FMENZZlplcUF5SnBoOEdZVGh1cUtDT0x2elBlTHhNR1A3blJI?= =?utf-8?B?ODI3QXdDTlY1ZHBMdmF6UHBwemU0bXY0MndIUUQ1Z1JvenVpMTJOSlZ0WXRI?= =?utf-8?B?NG1lcDZvQWdFOWVuMGVzN092bnpVcE9PdlB0RGE0L3JXakhqVWt6KzYyUUlY?= =?utf-8?B?aEpkalU3QlNrcGE4d3pOQWtMUjVvamxFbWc1QXZmbkxtUlYwVW5yZ0dIR0x3?= =?utf-8?B?aDF5OWZsK0EwWjVPcGluM0dhZW50aVI2S1dzdGZMWXpVdnViYmpEMlZUZStK?= =?utf-8?B?WlhNKzF0eDJmaU1udVFCWHhubDZFSXN3dVJxL0w4d2drYnBFYkFWUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: cfe095fd-418a-4af7-af14-08de78efa892 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:39:45.5083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZaPKb0knHZ6ZaL+0blJcVQOY++ICwKDguSK+3nLTKZK3+p8rwSLzBZ9YdayDTsct76rNLp1++BZ62rCUdgmCLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7329 X-OriginatorOrg: intel.com On 3/3/2026 2:31 PM, Zhang Rui wrote: > On Mon, 2026-03-02 at 17:43 +0100, Peter Zijlstra wrote: >> nt On Sat, Feb 28, 2026 at 03:35:26PM +0800, Chen, Yu C wrote: >> >>> Here we check packages0 and 1, should we check all the packages? >> >> Might as well I suppose. >> >> Could you boot queue/x86/topo on an snc-3 machine to verify it >> doesn't >> explode with all the paranoia on? > > Hi, Peter, > > regarding slit_validate() in > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=x86/topo&id=24ca94ac4b72803a7164b7ad84f06f0e9f0c49df > > I suppose we want to use > WARN_ON_ONCE(!slit_cluster_symmetric(n)) > rather than > WARN_ON_ONCE(slit_cluster_symmetric(n)); With Rui's fix, tested on GNR ,2 sockets, SNC3, NUMA distance symmetric platform, it works as expected, smp: Brought up 6 nodes, 384 CPUs domain-0: span=0,192 level=SMT domain-1: span=0-31,192-223 level=MC domain-2: span=0-95,192-287 level=NUMA groups: 0:{ span=0-31,192-223 cap=65536 }, 32:{ span=32-63,224-255 cap=65536 }, 64:{ span=64-95,256-287 cap=65536 } domain-3: span=0-383 level=NUMA groups: 0:{ span=0-95,192-287 cap=196608 }, 96:{ span=96-191,288-383 cap=196608 } resctrl also detects SNC3 root@a4bf018d7604:/sys/fs/resctrl/mon_data# tree mon_L3_00/ mon_L3_00/ ├── llc_occupancy ├── mbm_local_bytes ├── mbm_total_bytes ├── mon_sub_L3_00 │ ├── llc_occupancy │ ├── mbm_local_bytes │ └── mbm_total_bytes ├── mon_sub_L3_01 │ ├── llc_occupancy │ ├── mbm_local_bytes │ └── mbm_total_bytes └── mon_sub_L3_02 ├── llc_occupancy ├── mbm_local_bytes └── mbm_total_bytes > So > > Tested-by: Zhang Rui > For this series, Tested-by: Chen Yu thanks, Chenyu