From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Zhaolong Zhang <zhangzl2013@126.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: RE: [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus
Date: Tue, 9 Nov 2021 20:44:41 +0000 [thread overview]
Message-ID: <42d1d11d63f3453db61fad58a91e2ba5@intel.com> (raw)
In-Reply-To: <YYrYUpM7c5Z+nFsv@zn.tnic>
> what do we do with the sysfs knob? It probably is an ABI:
>
> /sys/devices/system/machinecheck/machinecheck1/tolerant
> /sys/devices/system/machinecheck/machinecheck2/tolerant
$ git grep tolerant -- Documentation/ABI/
$
An undocumented ABI! Well, not documented with all the other sysfs bits.
It does appear in:
Documentation/x86/x86_64/machinecheck.rst
Of course, like a lot of documentation, it isn't accurate. It wasn't
updated to describe what happens with recoverable errors.
Final paragraph says:
Note this only makes a difference if the CPU allows recovery
from a machine check exception. Current x86 CPUs generally do not.
Recovery was first introduced in the Nehalem generation which ark.intel.com
says was launched in Q1'2010. So over a decade.
Choices:
1) Leave the file there, but remove the code that uses the value
2) Delete the file too
Option 1 doesn't break any scripts that look for the file, but may make
people shout louder when they find it no longer does anything.
Option 2 is the more honest approach.
-Tony
next prev parent reply other threads:[~2021-11-09 20:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 7:44 [PATCH] x86/mce: correct cpu_missing reporting in mce_timed_out Zhaolong Zhang
2021-11-04 9:13 ` Borislav Petkov
2021-11-04 15:47 ` Luck, Tony
2021-11-04 18:02 ` Borislav Petkov
2021-11-05 2:19 ` Zhaolong Zhang
2021-11-08 8:28 ` [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus Zhaolong Zhang
2021-11-08 9:31 ` Borislav Petkov
2021-11-08 10:13 ` Zhaolong Zhang
2021-11-08 10:31 ` Borislav Petkov
2021-11-08 12:47 ` Zhaolong Zhang
2021-11-09 8:31 ` Zhaolong Zhang
2021-11-09 8:35 ` [PATCH] x86/mce: Get rid of cpu_missing Zhaolong Zhang
2021-11-09 9:15 ` Borislav Petkov
2021-11-09 14:19 ` Zhaolong Zhang
2021-11-09 9:07 ` [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus Borislav Petkov
2021-11-09 16:06 ` Luck, Tony
2021-11-09 19:48 ` Borislav Petkov
2021-11-09 19:50 ` Luck, Tony
2021-11-09 20:21 ` Borislav Petkov
2021-11-09 20:44 ` Luck, Tony [this message]
2021-11-09 21:30 ` Borislav Petkov
2021-12-20 20:43 ` [PATCH] x86/mce: Remove the tolerance level control Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42d1d11d63f3453db61fad58a91e2ba5@intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=x86@kernel.org \
--cc=zhangzl2013@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.