From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BD8C00140 for ; Wed, 24 Aug 2022 15:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237934AbiHXP47 convert rfc822-to-8bit (ORCPT ); Wed, 24 Aug 2022 11:56:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237589AbiHXP45 (ORCPT ); Wed, 24 Aug 2022 11:56:57 -0400 Received: from sender11-op-o11.zoho.eu (sender11-op-o11.zoho.eu [31.186.226.225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B74E47C326 for ; Wed, 24 Aug 2022 08:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661356609; cv=none; d=zohomail.eu; s=zohoarc; b=MpgXQTjyLdooLg1yHYQ6/5BnbWzdogsSl5uLhsURhPP50tMUptkTFLMUCKPzL6Fyb4UqNJnaDImqf3fOTxidETrBeKHz9VloVqbxipMEly+24g+oMpvVtEbpaKHkGHe98vfTg1Mpn4ANSuJDQbIl0FSaukzu3WeVQADLKajdeOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1661356609; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wAcg2r8KuLaCAHC0Aj0L7hcAxnIreQSXhUxUOglJw4M=; b=GU+0hVGhtaOcWVvSpldqnuxDZFzW74wSBCsY5Q+F/j7x1NDi8PTlZTOnsaRE2kI+qRSGF3JCZUhoOcax2hpFS+E/qw8bPyxRG9enuGlWFNEIM2Nm4csqXbh5nizC7jjUMlrwHCVm259mebrfySa4mmH3rEEK/9aQlWyzUsIIk+I= ARC-Authentication-Results: i=1; mx.zohomail.eu; spf=pass smtp.mailfrom=jes@trained-monkey.org; dmarc=pass header.from= Received: from [192.168.99.78] (pool-72-69-213-125.nycmny.fios.verizon.net [72.69.213.125]) by mx.zoho.eu with SMTPS id 1661356607277489.42549768851177; Wed, 24 Aug 2022 17:56:47 +0200 (CEST) Date: Wed, 24 Aug 2022 11:56:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3] Grow: Split Grow_reshape into helper function Content-Language: en-US To: Coly Li Cc: Mateusz Kusiak , linux-raid@vger.kernel.org References: <20220609074101.14132-1-mateusz.kusiak@intel.com> <9b885a13-21cf-3c9a-f320-c047301294de@trained-monkey.org> <2622AABD-75DC-41D4-9F1E-E958463E9FD0@suse.de> From: Jes Sorensen Message-ID: <42df7fa8-1a9a-afdc-5298-1850f5bce879@trained-monkey.org> In-Reply-To: <2622AABD-75DC-41D4-9F1E-E958463E9FD0@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On 8/8/22 06:03, Coly Li wrote: > > >> 2022年8月8日 04:41，Jes Sorensen 写道： >> >> On 6/9/22 03:41, Mateusz Kusiak wrote: >>> Grow_reshape should be split into helper functions given its size. >>> - Add helper function for preparing reshape on external metadata. >>> - Close cfd file descriptor. >>> Signed-off-by: Mateusz Kusiak >>> --- >>> Changes since v2: >>> - removed dot from commit message >>> - formatted commit description as a list >>> - got rid of returning -1 in prepare_external_reshape() >>> - changed "return" section in prepare_external_reshape() description >> >> Hi Mateusz, >> >> Changes look good to me, but it no longer applies. Mind sending an updated version? > > Hi Jes, > > Please check the version I post to you in series “mdadm-CI for-jes/20220728: patches for merge” (Message-Id: <20220728122101.28744-1-colyli@suse.de>), the patch in this series is rebased and confirmed with Mateusz, it could be applied to upstream mdadm. Hi I applied this one, but none of the versions applied cleanly. I had to play formail games to pull it out of your stack, as I am not going to apply a set of 23 commits in one batch without going through them. It's really awesome to have your help reviewing patches, much appreciated, but I would prefer to keep them in the original batches so I can pull them from patchwork, rather than trying to deal with the giant stack. Best regards, Jes