Re: [PATCH RFC] btrfs: Introduce btrfs_for_each_slot

[Nikolay Borisov <nborisov@suse.com>]

On 16.08.21 г. 15:21, Marcos Paulo de Souza wrote:
> On Mon, 2021-08-02 at 09:57 -0300, Marcos Paulo de Souza wrote:
>> There is a common pattern when search for a key in btrfs:
>>
>>  * Call btrfs_search_slot
>>  * Endless loop
>> 	 * If the found slot is bigger than the current items in the
>> leaf, check the
>> 	   next one
>> 	 * If still not found in the next leaf, return 1
>> 	 * Do something with the code
>> 	 * Increment current slot, and continue
>>
>> This pattern can be improved by creating an iterator macro, similar
>> to
>> those for_each_X already existing in the linux kernel. using this
>> approach means to reduce significantly boilerplate code, along making
>> it
>> easier to newcomers to understand how to code works.
>>
>> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
>> ---
>>
>>  I've being testing this approach in the last few weeks, and using
>> this macro
>>  all over the btrfs codebase, and not issues found yet. This is just
>> a RFC
>>  showing how the xattr code would benefit using the macro.
>>
>>  The only part that I didn't like was using the ret variable as a
>> macro
>>  argument, but I couldn't find a better way to do it...
>>
>>  That's why this is an RFC, so please comment :)
> 
> Gentle ping :)
> 


I didn't give a RB because the patch is too small in the sense that it
shows just a single caller. In order to be able to better ascertain how
useful is I was expecting you'd submit a larger series containing all
the necessary changes. Additionally, does this patch relate to the
changes in 'btrfs: Use btrfs_find_item whenever possible' or are those 2
independent?