From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: stable@dpdk.org, "Stojaczyk,
Dariusz" <dariusz.stojaczyk@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Wang, Xiao W" <xiao.w.wang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"qingfu.cqf@alibaba-inc.com" <qingfu.cqf@alibaba-inc.com>,
ferruh.yigit@intel.com
Subject: Re: [dpdk-stable] [PATCH v2] vfio: allow secondary process to query IOMMU type
Date: Mon, 21 Jan 2019 16:19:29 +0100 [thread overview]
Message-ID: <43003386.oRXqUKJA9s@xps> (raw)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A84626F2B3@HASMSX105.ger.corp.intel.com>
21/01/2019 11:29, Stojaczyk, Dariusz:
> > It is only possible to know IOMMU type of a given VFIO container
> > by attempting to initialize it. Since secondary process never
> > attempts to set up VFIO container itself (because they're shared
> > between primary and secondary), it never knows which IOMMU type
> > the container is using, and never sets up the appropriate config
> > structures. This results in inability to perform DMA mappings in
> > secondary process.
> >
> > Fix this by allowing secondary process to query IOMMU type of
> > primary's default container at device initialization.
> >
> > Note that this fix is assuming we're only interested in default
> > container.
> >
> > Bugzilla ID: 174
> >
> > Fixes: 6bcb7c95fe14 ("vfio: share default container in multi-process")
> > Cc: dariusz.stojaczyk@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
>
> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
>
> Thanks!
> In commit 6bcb7c95fe1 (vfio: share default container in multi-process) we fixed just the container fd and not the rte_vfio mapping APIs because we did not even use those APIs in SPDK.
Applied, thanks
prev parent reply other threads:[~2019-01-21 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 17:30 [PATCH] vfio: allow secondary process to query IOMMU type Anatoly Burakov
2019-01-18 10:13 ` Burakov, Anatoly
2019-01-18 10:24 ` [PATCH v2] " Anatoly Burakov
2019-01-19 3:23 ` Wang, Xiao W
2019-01-21 10:13 ` Burakov, Anatoly
2019-01-21 10:21 ` Thomas Monjalon
2019-01-21 10:29 ` Burakov, Anatoly
2019-01-21 10:29 ` Stojaczyk, Dariusz
2019-01-21 15:19 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43003386.oRXqUKJA9s@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qingfu.cqf@alibaba-inc.com \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.