From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1E4hN5-0000pM-HO for mharc-grub-devel@gnu.org; Mon, 15 Aug 2005 11:59:32 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E4hMz-0000lK-CP for grub-devel@gnu.org; Mon, 15 Aug 2005 11:59:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E4hMx-0000k8-B7 for grub-devel@gnu.org; Mon, 15 Aug 2005 11:59:24 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E4hMw-0000gk-MO for grub-devel@gnu.org; Mon, 15 Aug 2005 11:59:23 -0400 Received: from [194.251.242.244] (helo=fep19.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E4hVv-0001zA-Bi for grub-devel@gnu.org; Mon, 15 Aug 2005 12:08:39 -0400 Received: from [80.222.166.89] by fep19.inet.fi with ESMTP id <20050815155246.WIVQ9928.fep19.inet.fi@[80.222.166.89]> for ; Mon, 15 Aug 2005 18:52:46 +0300 Message-ID: <4300BA58.1010706@nic.fi> Date: Mon, 15 Aug 2005 18:52:56 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 1.0+ (Windows/20050809) MIME-Version: 1.0 To: The development of GRUB 2 References: <42FF3097.7030904@nic.fi> <42FF75B0.8060805@gmail.com> <42FFBC3A.9010708@nic.fi> <200508150019.30101.okuji@enbug.org> In-Reply-To: <200508150019.30101.okuji@enbug.org> X-Enigmail-Version: 0.92.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: vesafb terminal for testing. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2005 15:59:29 -0000 Yoshinori K. Okuji wrote: > On Sunday 14 August 2005 23:48, Vesa Jääskeläinen wrote: >> As far I know, GRUB 2 doesn't support dynamic loading of function entry >> points, instead there are only two predefined entry points that can be >> called from modules so there has to be some interface for those if they >> are not implemented in kernel level. And it would be bad to duplicate >> that code in several places. > > Nope. GRUB 2 supports real dynamic loading. Entry points are used only when we > want to allow symbols to be missing. So you need to implement code in the > kernel only if it requires real mode or it is a critical function. Impressive I must say :) It was even transparent. Now only problem is what is the best location for vbe.c that would contain helper functions for modules that needs VBE. Currently I have it in term/i386/pc/vbe.c but is there better location for this? And is GRUB_MOD_INIT and GRUB_MOD_FINI mandory as I do not have need for those in this module? Seems to work without them. Is the file include/grub/i386/pc/vbe.h correct place to put function prototypes? Is directory commands/i386/pc/ correct place for commands vbe_list_modes and vbe_test? Thanks, Vesa Jääskeläinen