From: Jeff Garzik <jgarzik@pobox.com>
To: Greg KH <greg@kroah.com>
Cc: Brett Russ <russb@emc.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg KH <gregkh@suse.de>
Subject: Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup
Date: Mon, 15 Aug 2005 15:17:02 -0400 [thread overview]
Message-ID: <4300EA2E.4010303@pobox.com> (raw)
In-Reply-To: <20050815185732.GA15216@kroah.com>
Greg KH wrote:
> On Fri, Aug 12, 2005 at 06:43:03PM -0400, Brett Russ wrote:
>
>>Simple cleanup to eliminate X copies of the pci_enable_intx() function
>>in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout
>>libata and msi.c.
>>
>>Signed-off-by: Brett Russ <russb@emc.com>
>
>
> It would have been nice if you had built this code :(
>
> Hint, get rid of all TRUE and FALSE usages in your patch. Care to try
> again?
just manually s/TRUE/1/ and s/FALSE/0/ in the patch...
I could have sworn TRUE and FALSE were in linux/kernel.h, but it looks
like I was wrong.
Jeff
next prev parent reply other threads:[~2005-08-15 19:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-03 20:47 [PATCH 2.6.12.3] PCI/libata INTx cleanup Brett Russ
2005-08-11 19:01 ` Jeff Garzik
2005-08-12 17:10 ` Brett Russ
2005-08-12 17:10 ` Brett Russ
2005-08-12 18:22 ` Greg KH
2005-08-12 18:49 ` Brett Russ
2005-08-12 21:30 ` Jeff Garzik
2005-08-12 22:43 ` [PATCH 2.6.13-rc6] " Brett Russ
2005-08-13 0:29 ` Jeff Garzik
2005-08-15 16:31 ` Greg KH
2005-08-15 18:57 ` Greg KH
2005-08-15 19:08 ` Brett Russ
2005-08-15 20:06 ` Greg KH
2005-08-15 20:17 ` Brett Russ
2005-08-15 19:17 ` Jeff Garzik [this message]
2005-08-15 19:23 ` Brett M Russ
[not found] ` <1126218402469@kroah.com>
2005-09-09 13:04 ` [PATCH 2.6.13] PCI/libata INTx bug fix Brett M Russ
2005-09-09 15:37 ` Jeff Garzik
2005-09-09 17:02 ` [PATCH] PCI: " Greg KH
2005-09-09 17:04 ` Jeff Garzik
2005-08-12 21:44 ` [PATCH 2.6.12.3] PCI/libata INTx cleanup Brian Gerst
2005-08-12 21:49 ` Greg KH
2005-08-12 21:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4300EA2E.4010303@pobox.com \
--to=jgarzik@pobox.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=russb@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.