From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1E4nAo-0003Bd-Ks
	for mharc-grub-devel@gnu.org; Mon, 15 Aug 2005 18:11:14 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1E4nAY-00035T-FR
	for grub-devel@gnu.org; Mon, 15 Aug 2005 18:10:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1E4nAR-00034P-DI
	for grub-devel@gnu.org; Mon, 15 Aug 2005 18:10:53 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1E4n6c-0001NK-CY
	for grub-devel@gnu.org; Mon, 15 Aug 2005 18:06:54 -0400
Received: from [194.251.242.244] (helo=fep19.inet.fi)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1E4mvI-0001tz-1R
	for grub-devel@gnu.org; Mon, 15 Aug 2005 17:55:12 -0400
Received: from [80.222.166.89] by fep19.inet.fi with ESMTP
	id <20050815213919.XLIT9928.fep19.inet.fi@[80.222.166.89]>
	for <grub-devel@gnu.org>; Tue, 16 Aug 2005 00:39:19 +0300
Message-ID: <43010B92.3030900@nic.fi>
Date: Tue, 16 Aug 2005 00:39:30 +0300
From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= <chaac@nic.fi>
User-Agent: Thunderbird 1.0+ (Windows/20050809)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <42FF3097.7030904@nic.fi>
	<87zmrjxge4.fsf@student.han.nl>	<430103AD.1090800@nic.fi>
	<87acjivquh.fsf@student.han.nl>
In-Reply-To: <87acjivquh.fsf@student.han.nl>
X-Enigmail-Version: 0.92.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: vesafb terminal for testing.
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Aug 2005 22:10:59 -0000

Marco Gerards wrote:
> Vesa Jääskeläinen <chaac@nic.fi> writes:
> 
>>> There are some long lines, can you please make them shorter so
>>> the maximal line length is 78 characters?
>> Hmm... I made another scan for those. Still I left some of those there
>> because in my opinion it is much more readable in that way. But splitted
>> some lines.
> 
> Can you should me which so I can come up with a suggestion?

video/i386/pc/vbe.c:
- setpixel functions. There are couple of "too" long lines.
- grub_vbe_get_video_mode_info first variable definition is a bit long.

term/i386/pc/vesafb.c:
- grub_virtual_screen_setup, grub_malloc line.
- write_char, set pixel line at end.
- scroll_up, last memmove line.
- grub_virtual_screen_setcolor, function definition.
- GRUB_MOD_INIT.

commands/i386/pc/vbe_test.c:
- GRUB_MOD_INIT.

commands/i386/pc/vbe_list_modes.c:
- GRUB_MOD_INIT.

include/grub/i386/pc/vbe.h:
- several function prototypes.

>> I will scan the code once more and then commit a bit different version
>> to CVS as Okuji asked to commit it to there for easier testing.

Just a note until admins fix those commit messages, first version of vbe
terminal support is now committed. It still needs more work, but it is a
starting point.