From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: Re: [PATCH 2/2] intelfb/fbdev: Save info->flags in a local variable Date: Tue, 16 Aug 2005 05:51:11 +0800 Message-ID: <43010E4F.6090502@gmail.com> References: <430098A7.1080102@gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1E4msF-0007Pw-0y for linux-fbdev-devel@lists.sourceforge.net; Mon, 15 Aug 2005 14:52:03 -0700 Received: from wproxy.gmail.com ([64.233.184.196]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1E4msD-0000DL-NE for linux-fbdev-devel@lists.sourceforge.net; Mon, 15 Aug 2005 14:52:03 -0700 Received: by wproxy.gmail.com with SMTP id i21so10574wra for ; Mon, 15 Aug 2005 14:51:55 -0700 (PDT) In-Reply-To: Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Linus Torvalds Cc: Andrew Morton , Sylvain Meyer , Pavel Kysilka , Linux Fbdev development list Linus Torvalds wrote: > > On Mon, 15 Aug 2005, Antonino A. Daplas wrote: >> @@ -697,7 +697,7 @@ fb_set_var(struct fb_info *info, struct >> !list_empty(&info->modelist)) >> err = fb_add_videomode(&mode, &info->modelist); >> >> - if (!err && info->flags & FBINFO_MISC_USEREVENT) { >> + if (!err && flags & FBINFO_MISC_USEREVENT) { >> struct fb_event event; >> int evnt = (var->activate & FB_ACTIVATE_ALL) ? >> FB_EVENT_MODE_CHANGE_ALL : > > This doesn't match my tree - I assume we're talking about the -mm tree > here. > > I can/will fix up the thing by hand, but somebody should check it. > > Linus > Sorry about that, I forgot. I checked your git tree, and it looks good. Thanks. Tony ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf