From: Mika Kukkonen <mikukkon@gmail.com>
To: ambx1@neo.rr.com, perex@suse.cz
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix compile warning in drivers/pnp/resource.c with !CONFIG_PCI
Date: Mon, 21 Mar 2005 20:40:19 +0200 [thread overview]
Message-ID: <4301cff605032110402f521ce8@mail.gmail.com> (raw)
With !CONFIG_PCI I get following warning:
CC drivers/pnp/resource.o
drivers/pnp/resource.c:24: warning: `pnp_skip_pci_scan' defined but not used
Two ways to fix this, first one would be to simply #ifdef the
variable. But the variable
in question is not (according to cscope) actually used outside this
one other place (and reason why it became a warning now is that Adrian
made it static), and so the code inside CONFIG_PCI is actually relying
on the fact that the variable is implicitly initialized to 0.
So the patch just deletes the variable.
--MiKu
Signed-off-by: Mika Kukkonen (mikukkon@gmail.com)
--- 1.25/drivers/pnp/resource.c 2005-03-14 01:29:58 +02:00
+++ edited/resource.c 2005-03-21 19:41:54 +02:00
@@ -21,7 +21,6 @@
#include <linux/pnp.h>
#include "base.h"
-static int pnp_skip_pci_scan; /* skip PCI
resource scanning */
static int pnp_reserve_irq[16] = { [0 ... 15] = -1 }; /* reserve
(don't use) some IRQ */
static int pnp_reserve_dma[8] = { [0 ... 7] = -1 }; /* reserve
(don't use) some DMA */
static int pnp_reserve_io[16] = { [0 ... 15] = -1 }; /* reserve
(don't use) some I/O region */
@@ -385,7 +384,7 @@
#ifdef CONFIG_PCI
/* check if the resource is being used by a pci device */
- if (!pnp_skip_pci_scan) {
+ {
struct pci_dev * pci = NULL;
while ((pci = pci_find_device(PCI_ANY_ID, PCI_ANY_ID,
pci)) != NULL) {
if (pci->irq == *irq)
next reply other threads:[~2005-03-21 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 18:40 Mika Kukkonen [this message]
2005-03-22 6:01 ` [PATCH] Fix compile warning in drivers/pnp/resource.c with !CONFIG_PCI Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4301cff605032110402f521ce8@mail.gmail.com \
--to=mikukkon@gmail.com \
--cc=akpm@osdl.org \
--cc=ambx1@neo.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.