From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
Subject: Re: [Patch] by default don't give all memory to dom0
Date: Thu, 18 Aug 2005 20:50:57 +0100
Message-ID: <4304E6A1.7090800@blueyonder.co.uk>
References: <20050818122413.C17270@unix-os.sc.intel.com>
Reply-To: david.nospam.hopwood@blueyonder.co.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20050818122413.C17270@unix-os.sc.intel.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Siddha, Suresh B wrote:
[...]

> +static void parse_reserve_dmamem(char *s)
> +{
> +    unsigned long long bytes = parse_size_and_unit(s);
> +    /* If no unit is specified we default to kB units, not bytes. */
> +    if ( isdigit(s[strlen(s)-1]) )
> +        reserve_dmapages = (unsigned int)bytes >> (PAGE_SHIFT - 10);
> +    else
> +        reserve_dmapages = (unsigned int)(bytes >> PAGE_SHIFT);
> +}

Shouldn't the default unit be consistent for all Xen memory parameters?

-- 
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>