All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Stes <stes@pandora.be>
To: netfilter-devel@lists.netfilter.org
Subject: RPC and RSH modules
Date: Fri, 19 Aug 2005 10:56:07 +0200	[thread overview]
Message-ID: <43059EA7.2080401@pandora.be> (raw)
In-Reply-To: <20050703140250.GC3186@sunbeam.de.gnumonks.org>

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]


Hello,

The current RPC/RSH modules will kernel panic on 2.6.12.4 if you use 
them *without* the following patch.

(see patch in attach which fixes the kernel panic)

The patch sets timeout to nonzero and sets exp->master = ct  because 
ip_conntrack_expect_related()
does a :

    if (expect->master->helper->max_expected)

This will dereference a NULL pointer and kernel panic if expect->master 
is not initialized.

Because the old conntrack modules did NOT set exp->master = ct, I think 
it would be a good idea to

    BUG_ON(expect->master == NULL);

in the ip_conntrack_core.c at line 827 in function 
ip_conntrack_expect_related() before actually accessing the 
expect->master structure.

Is it please possible to add the following patches (rpc-rsh.tar.gz) to 
the SVN repository of "patch-o-matic-ng".

Thanks a lot.


[-- Attachment #2: rpc-rsh.tar.gz --]
[-- Type: application/gzip, Size: 60006 bytes --]

      parent reply	other threads:[~2005-08-19  8:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-03 12:48 svn diff for Legato NetWorker RPC/RSH modules David Stes
2005-07-03 14:02 ` Harald Welte
2005-07-03 14:21   ` David Stes
2005-08-13  5:21   ` port to Linux 2.6 of the RPC/ RSH modules David Stes
2005-08-16 16:39     ` Jan Engelhardt
2005-08-19  8:56   ` David Stes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43059EA7.2080401@pandora.be \
    --to=stes@pandora.be \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.