All of lore.kernel.org
 help / color / mirror / Atom feed
From: r.marek@sh.cvut.cz (Rudolf Marek)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] A few remarks about the w83792d
Date: Fri, 19 Aug 2005 17:38:33 +0000	[thread overview]
Message-ID: <4305FCE8.6040602@sh.cvut.cz> (raw)
In-Reply-To: <43045711.6040804@fr.thalesgroup.com>

Hi all,

> we are starting to use the driver on our machines and we noticed to
> things that we feel should be changed :
>  - the values in /etc/sensors.conf for the CPU temperature threshold are
> very low (max:42? hyst:37?). This supersed the values set in the BIOS
> and is very low, causing the PC to beep everytime the CPU is loaded at 100%
>  - when we read the sensors with sensors, we see the following message

Ahh correct. I will comment it out in example config. Must remained from driver testing.
I will fix it in CVS.

> on the console :
>  w83792d 0-002f: Starting device update.

Yes this was already fixed. The driver is now in -mm tree of linux and perhaps will show up in 2.6.14 kernel.
Also the driver now contains latest sysfs subsystem updates and some cleanups. What was paticulary changed
can be seen here: http://assembler.cz/download/w83792d/ (please note that this is not exactly what is in kernel now)

I assume your customer is not running latest kernel so here is the list what you should fix:

0) fix for this update issue (should fix)
1) fix detection probe range (should fix)
2) fix subclient registration (if you want to handle special cases when some of subclients are disabled in HW)
3) fix documentation (should fix)

Fix for 0)
http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050706/3a674472/w83792d-driver-QUIET-2.6.x.patch-0001.gz
(in this thread http://lists.lm-sensors.org/pipermail/lm-sensors/2005-July/012919.html)

Fix for 1)

Please add two more addresses so it looks like this:

+/* Addresses to scan */
+static unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, 0x2f, I2C_CLIENT_END };

Fix for 2)

This patch is for modified driver but you should get the idea.
http://assembler.cz/download/w83792d/04-fix-disabled-subclients

Here you can read more about this:
http://lists.lm-sensors.org/pipermail/lm-sensors/2005-July/012940.html

Fix for 3)

Contact at Winbond has been changed. Please ship this version of documenation
http://lists.lm-sensors.org/pipermail/lm-sensors/2005-July/013099.html

>  thank you for your help and your work on lmsensors !

Ahh it always makes me happy :)

Regards

Rudolf

      reply	other threads:[~2005-08-19 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-18 11:39 [lm-sensors] A few remarks about the w83792d P.O. Gaillard
2005-08-19 17:38 ` Rudolf Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4305FCE8.6040602@sh.cvut.cz \
    --to=r.marek@sh.cvut.cz \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.