All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Anton Altaparmakov <aia21@cam.ac.uk>,
	vandrove@vc.cvut.cz, Andrew Morton <akpm@osdl.org>,
	linware@sh.cvut.cz, fsdevel <linux-fsdevel@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: Kernel bug: Bad page state: related to generic symlink code and mmap
Date: Fri, 19 Aug 2005 22:16:47 +0300	[thread overview]
Message-ID: <4306301F.9060707@kolumbus.fi> (raw)
In-Reply-To: <20050819180218.GE29811@parcelfarce.linux.theplanet.co.uk>

Al Viro wrote:

>On Fri, Aug 19, 2005 at 05:53:32PM +0100, Al Viro wrote:
>  
>
>>I'm taking NFS helpers to libfs.c and switching ncpfs to them.  IMO that's
>>better than copying the damn thing and other network filesystems might have
>>the same needs eventually...
>>    
>>
>
>[something like this - completely untested]
>
>* stray_page_get_link(inode, filler) - returns ERR_PTR(error) or pointer
>to symlink body.  Said symlink body sits in a page at offset equal to
>offsetof(page, struct stray_page_link).  filler() is expected to put it
>at such offset. Page is cached.
>
>* stray_page_put_link() - ->put_link() suitable for links obtained from
>stray_page_get_link().  Unlike the usual pagecache-based variants, this
>sucker does _not_ rely on page staying cached.
>
>* nfs and ncpfs switched to the helpers above.
>
>Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
>----
>  
>

Just out of curiosity - what protects even local filesystems against 
concurrent truncate and symlink resolving when using the page cache helpers?

--Mika


  parent reply	other threads:[~2005-08-19 19:15 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-19 11:14 Kernel bug: Bad page state: related to generic symlink code and mmap Anton Altaparmakov
2005-08-19 14:20 ` Al Viro
2005-08-19 15:44   ` Anton Altaparmakov
2005-08-19 15:58     ` Al Viro
2005-08-19 16:07     ` Linus Torvalds
2005-08-19 16:21       ` Al Viro
2005-08-19 16:21       ` Linus Torvalds
2005-08-19 16:43         ` Linus Torvalds
2005-08-19 16:53           ` Al Viro
2005-08-19 18:02             ` Al Viro
2005-08-19 18:00               ` Christoph Hellwig
2005-08-19 19:38                 ` Al Viro
2005-08-19 19:41                   ` Matthew Wilcox
2005-08-19 19:43                     ` Al Viro
2005-08-19 21:19                       ` Christoph Hellwig
2005-08-19 20:35                   ` Linus Torvalds
2005-08-19 21:20                     ` Anton Altaparmakov
2005-08-19 21:35                       ` Linus Torvalds
2005-08-19 21:42                     ` Al Viro
2005-08-19 19:16               ` Mika Penttilä [this message]
2005-08-19 19:40                 ` Al Viro
2005-08-19 19:40                   ` Al Viro
2005-08-19 19:50                   ` Mika Penttilä
2005-08-19 19:50                     ` Mika Penttilä
2005-08-19 20:46           ` Anton Altaparmakov
2005-08-19 20:55             ` Linus Torvalds
2005-08-19 21:39               ` Anton Altaparmakov
2005-08-19 22:04                 ` Linus Torvalds
2005-08-19 23:15                   ` Al Viro
2005-08-19 23:17                     ` Al Viro
2005-08-20  1:08                     ` Linus Torvalds
2005-08-20  1:15                       ` Al Viro
2005-08-20 12:49                   ` Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4306301F.9060707@kolumbus.fi \
    --to=mika.penttila@kolumbus.fi \
    --cc=aia21@cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linware@sh.cvut.cz \
    --cc=torvalds@osdl.org \
    --cc=vandrove@vc.cvut.cz \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.