All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Peer.Chen@uli.com.tw
Cc: Alexey Dobriyan <adobriyan@gmail.com>, Alan Cox <alan@redhat.com>,
	Clear.Zhang@uli.com.tw, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Emily.Jiang@uli.com.tw
Subject: Re: [patch] net/tulip: LAN driver for ULI M5261/M5263
Date: Sat, 20 Aug 2005 01:12:25 -0400	[thread overview]
Message-ID: <4306BBB9.4060201@pobox.com> (raw)
In-Reply-To: <OF308CFA6C.C728268D-ON4825705F.00365A7A@uli.com.tw>

Peer.Chen@uli.com.tw wrote:
> Jeff:
> The attached file is the incremental patch to the original uli526x.c I send
> you first time,
> I modify the source according to your advice, thanks.
> 
> Signed-off-by: Peer Chen <Peer.Chen@uli.com.tw>
> (See attached file: patch_uli526x_inc)

Patch applied, thanks much.

I notice you removed the following code, rather than fixing it.  It is
OK to remove this code??


-       //add by clearzhang 2004/7/8
-       pci_read_config_dword(pdev,0x0,&configval);
-       m526x_id = configval;
-       if(configval == 0x526310b9)
-       {
-               //printk("is m5263\n");
-               pci_read_config_dword(pdev,0x0c,&configval);
-               configval = ((configval & 0xffff00ff) | 0x8000);
-               pci_write_config_dword(pdev,0x0c,configval);
-       }

Thanks,

	Jeff



  reply	other threads:[~2005-08-20  5:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-16  9:58 Re: [patch] net/tulip: LAN driver for ULI M5261/M5263 Peer.Chen
2005-08-20  5:12 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-07-29 12:15 Peer.Chen
2005-07-29 19:37 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4306BBB9.4060201@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=Clear.Zhang@uli.com.tw \
    --cc=Emily.Jiang@uli.com.tw \
    --cc=Peer.Chen@uli.com.tw \
    --cc=adobriyan@gmail.com \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.