Re: [PATCH 1/2] string match for iptables

[Patrick McHardy <kaber@trash.net>]

Pablo Neira wrote:
> Here comes the iptables string match since the textsearch infrastructure
> went into 2.6.13. This adds to iptables the ability of looking for given
> patterns in packets. I'll be happy to see this stuff in Davem's 2.6.14
> tree ;)

> +struct ipt_string_info
> +{
> +	u_int16_t		from_offset;
> +	u_int16_t		to_offset;
> +	char			algo[IPT_STRING_MAX_ALGO_NAME_SIZE];
> +	char			pattern[IPT_STRING_MAX_PATTERN_SIZE];
> +	u_int8_t		patlen;
> +	u_int8_t		invert;
> +	struct ts_config	*config;
> +};

Embedding a pointer in the struct causes different alignment depending
on the wordsize and doesn't work in mixed 64/32 bit environments.
Please use __attribute__((aligned(8))) to prevent this.

Otherwise, it looks good.