From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C4EEC2BB3F for ; Mon, 20 Nov 2023 17:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tNHggnG9JrzGz8N2Bp1mFxF1X6A/9BjIydaWEhWLWBE=; b=VNjFrpKzyLdmRv fiKEcZdM+V7Iw3zTi682oa565odPuUhLkCpboFNWjN1kkkW+smdCWTGS6tjym3Dx/z8UjnhqfvUO0 ttZ79l35dIQCk6uF0VETojNfCArwpWjDxEzVZdV5zyTBZnujtfFQhz2i1hCfAhw8gXXkGeqwvXrUy hqp/Xvo7+q8rRLCFbXXNDeBbha4bRScvNZh7K149chuhbdnTpFPa9eUMW0xS+2Zg9Bp23ya06FcvY pqfNhbCLEsuMXR915DFVpy8LY82VYkBCoumTU5yHf+IXMcsXsNGibA2unzGAgccU1sSmGUXyHz0er CJzchgmoRNl43/im7ijg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r57je-00Dasx-13; Mon, 20 Nov 2023 17:06:58 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r57jT-00Dagv-0d; Mon, 20 Nov 2023 17:06:49 +0000 Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r57jP-0000mH-3V; Mon, 20 Nov 2023 18:06:43 +0100 From: Heiko Stuebner To: hjc@rock-chips.com, Johan Jonker Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/4] drm/rockchip: rk3066_hdmi: Remove useless output format Date: Mon, 20 Nov 2023 18:06:42 +0100 Message-ID: <4308014.ejJDZkT8p0@phil> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_090647_359877_998389C0 X-CRM114-Status: GOOD ( 20.47 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Johan, Am Donnerstag, 2. November 2023, 14:42:19 CET schrieb Johan Jonker: > The Rk3066 hdmi output format is hard coded to RGB. Remove > all useless code related to colorimetry and enc_out_format. > > Signed-off-by: Johan Jonker I guess my first question is, is the hardcoding happening just because of missing functionality in the driver, or does the hardware only support RGB? > --- > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > index 0e7aae341960..f2b1b2faa096 100644 > --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c > +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > @@ -23,8 +23,6 @@ > > struct hdmi_data_info { > int vic; /* The CEA Video ID (VIC) of the current drm display mode. */ > - unsigned int enc_out_format; > - unsigned int colorimetry; > }; > > struct rk3066_hdmi_i2c { > @@ -200,14 +198,7 @@ static int rk3066_hdmi_config_avi(struct rk3066_hdmi *hdmi, > rc = drm_hdmi_avi_infoframe_from_display_mode(&frame.avi, > &hdmi->connector, mode); > > - if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV444) > - frame.avi.colorspace = HDMI_COLORSPACE_YUV444; > - else if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV422) > - frame.avi.colorspace = HDMI_COLORSPACE_YUV422; > - else > - frame.avi.colorspace = HDMI_COLORSPACE_RGB; > - > - frame.avi.colorimetry = hdmi->hdmi_data.colorimetry; > + frame.avi.colorspace = HDMI_COLORSPACE_RGB; > frame.avi.scan_mode = HDMI_SCAN_MODE_NONE; > > return rk3066_hdmi_upload_frame(hdmi, rc, &frame, > @@ -329,15 +320,6 @@ static int rk3066_hdmi_setup(struct rk3066_hdmi *hdmi, > struct drm_display_info *display = &hdmi->connector.display_info; > > hdmi->hdmi_data.vic = drm_match_cea_mode(mode); > - hdmi->hdmi_data.enc_out_format = HDMI_COLORSPACE_RGB; > - > - if (hdmi->hdmi_data.vic == 6 || hdmi->hdmi_data.vic == 7 || > - hdmi->hdmi_data.vic == 21 || hdmi->hdmi_data.vic == 22 || > - hdmi->hdmi_data.vic == 2 || hdmi->hdmi_data.vic == 3 || > - hdmi->hdmi_data.vic == 17 || hdmi->hdmi_data.vic == 18) > - hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_601; > - else > - hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_709; while I can understand the RGB output format, why does the colorimetry also get removed? This looks like it is dependent on the mode itself and not the output format? Thanks Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34D5BC2BB3F for ; Mon, 20 Nov 2023 17:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sv2LCOqjGiwsnbA5fkhu3G6FOjgilBvUPle5HDUCCYw=; b=nojdGHM0lt7kkt DmlkXf8h0NScMpVXC5RBVuXLWvL63epyNxj05mjx7fkSVe9W0QCArx/CtTdDNzYSgqiqj/pG0Z3On BD+jNyx/Wi+Kmu3DffqWPHNbFz6j/Jp9jVbpXMcBQqqNWB/c5xHYh0/qhyfQkMj+3W/TNHaTNtxsE xPM1PwNRzW6SEv0C0Ksc+WbZG0Jfj7LRJhPiCDkKw+H7VPefUInO+hy2UAWIz2YzsPb04JkPfukhl JkkpI+0oNTQERFGf96lx86i7cudSqzKq4jVlX1LXCJRHnIuHrAgSxzNKfeG6i0Ir4blIVB3JiOkeJ /oTBnQ+Tb9Ggw8tjLBxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r57ja-00Daoq-11; Mon, 20 Nov 2023 17:06:54 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r57jT-00Dagv-0d; Mon, 20 Nov 2023 17:06:49 +0000 Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r57jP-0000mH-3V; Mon, 20 Nov 2023 18:06:43 +0100 From: Heiko Stuebner To: hjc@rock-chips.com, Johan Jonker Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/4] drm/rockchip: rk3066_hdmi: Remove useless output format Date: Mon, 20 Nov 2023 18:06:42 +0100 Message-ID: <4308014.ejJDZkT8p0@phil> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_090647_359877_998389C0 X-CRM114-Status: GOOD ( 20.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Johan, Am Donnerstag, 2. November 2023, 14:42:19 CET schrieb Johan Jonker: > The Rk3066 hdmi output format is hard coded to RGB. Remove > all useless code related to colorimetry and enc_out_format. > > Signed-off-by: Johan Jonker I guess my first question is, is the hardcoding happening just because of missing functionality in the driver, or does the hardware only support RGB? > --- > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > index 0e7aae341960..f2b1b2faa096 100644 > --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c > +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > @@ -23,8 +23,6 @@ > > struct hdmi_data_info { > int vic; /* The CEA Video ID (VIC) of the current drm display mode. */ > - unsigned int enc_out_format; > - unsigned int colorimetry; > }; > > struct rk3066_hdmi_i2c { > @@ -200,14 +198,7 @@ static int rk3066_hdmi_config_avi(struct rk3066_hdmi *hdmi, > rc = drm_hdmi_avi_infoframe_from_display_mode(&frame.avi, > &hdmi->connector, mode); > > - if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV444) > - frame.avi.colorspace = HDMI_COLORSPACE_YUV444; > - else if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV422) > - frame.avi.colorspace = HDMI_COLORSPACE_YUV422; > - else > - frame.avi.colorspace = HDMI_COLORSPACE_RGB; > - > - frame.avi.colorimetry = hdmi->hdmi_data.colorimetry; > + frame.avi.colorspace = HDMI_COLORSPACE_RGB; > frame.avi.scan_mode = HDMI_SCAN_MODE_NONE; > > return rk3066_hdmi_upload_frame(hdmi, rc, &frame, > @@ -329,15 +320,6 @@ static int rk3066_hdmi_setup(struct rk3066_hdmi *hdmi, > struct drm_display_info *display = &hdmi->connector.display_info; > > hdmi->hdmi_data.vic = drm_match_cea_mode(mode); > - hdmi->hdmi_data.enc_out_format = HDMI_COLORSPACE_RGB; > - > - if (hdmi->hdmi_data.vic == 6 || hdmi->hdmi_data.vic == 7 || > - hdmi->hdmi_data.vic == 21 || hdmi->hdmi_data.vic == 22 || > - hdmi->hdmi_data.vic == 2 || hdmi->hdmi_data.vic == 3 || > - hdmi->hdmi_data.vic == 17 || hdmi->hdmi_data.vic == 18) > - hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_601; > - else > - hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_709; while I can understand the RGB output format, why does the colorimetry also get removed? This looks like it is dependent on the mode itself and not the output format? Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C572DC197A0 for ; Mon, 20 Nov 2023 17:06:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E573D10E0DD; Mon, 20 Nov 2023 17:06:48 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3C3410E0DD for ; Mon, 20 Nov 2023 17:06:45 +0000 (UTC) Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r57jP-0000mH-3V; Mon, 20 Nov 2023 18:06:43 +0100 From: Heiko Stuebner To: hjc@rock-chips.com, Johan Jonker Subject: Re: [PATCH v1 3/4] drm/rockchip: rk3066_hdmi: Remove useless output format Date: Mon, 20 Nov 2023 18:06:42 +0100 Message-ID: <4308014.ejJDZkT8p0@phil> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Johan, Am Donnerstag, 2. November 2023, 14:42:19 CET schrieb Johan Jonker: > The Rk3066 hdmi output format is hard coded to RGB. Remove > all useless code related to colorimetry and enc_out_format. > > Signed-off-by: Johan Jonker I guess my first question is, is the hardcoding happening just because of missing functionality in the driver, or does the hardware only support RGB? > --- > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > index 0e7aae341960..f2b1b2faa096 100644 > --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c > +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > @@ -23,8 +23,6 @@ > > struct hdmi_data_info { > int vic; /* The CEA Video ID (VIC) of the current drm display mode. */ > - unsigned int enc_out_format; > - unsigned int colorimetry; > }; > > struct rk3066_hdmi_i2c { > @@ -200,14 +198,7 @@ static int rk3066_hdmi_config_avi(struct rk3066_hdmi *hdmi, > rc = drm_hdmi_avi_infoframe_from_display_mode(&frame.avi, > &hdmi->connector, mode); > > - if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV444) > - frame.avi.colorspace = HDMI_COLORSPACE_YUV444; > - else if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV422) > - frame.avi.colorspace = HDMI_COLORSPACE_YUV422; > - else > - frame.avi.colorspace = HDMI_COLORSPACE_RGB; > - > - frame.avi.colorimetry = hdmi->hdmi_data.colorimetry; > + frame.avi.colorspace = HDMI_COLORSPACE_RGB; > frame.avi.scan_mode = HDMI_SCAN_MODE_NONE; > > return rk3066_hdmi_upload_frame(hdmi, rc, &frame, > @@ -329,15 +320,6 @@ static int rk3066_hdmi_setup(struct rk3066_hdmi *hdmi, > struct drm_display_info *display = &hdmi->connector.display_info; > > hdmi->hdmi_data.vic = drm_match_cea_mode(mode); > - hdmi->hdmi_data.enc_out_format = HDMI_COLORSPACE_RGB; > - > - if (hdmi->hdmi_data.vic == 6 || hdmi->hdmi_data.vic == 7 || > - hdmi->hdmi_data.vic == 21 || hdmi->hdmi_data.vic == 22 || > - hdmi->hdmi_data.vic == 2 || hdmi->hdmi_data.vic == 3 || > - hdmi->hdmi_data.vic == 17 || hdmi->hdmi_data.vic == 18) > - hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_601; > - else > - hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_709; while I can understand the RGB output format, why does the colorimetry also get removed? This looks like it is dependent on the mode itself and not the output format? Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 167DCC197A0 for ; Mon, 20 Nov 2023 17:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233543AbjKTRHU (ORCPT ); Mon, 20 Nov 2023 12:07:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231944AbjKTRHC (ORCPT ); Mon, 20 Nov 2023 12:07:02 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDEB2D6A for ; Mon, 20 Nov 2023 09:06:47 -0800 (PST) Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r57jP-0000mH-3V; Mon, 20 Nov 2023 18:06:43 +0100 From: Heiko Stuebner To: hjc@rock-chips.com, Johan Jonker Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/4] drm/rockchip: rk3066_hdmi: Remove useless output format Date: Mon, 20 Nov 2023 18:06:42 +0100 Message-ID: <4308014.ejJDZkT8p0@phil> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, Am Donnerstag, 2. November 2023, 14:42:19 CET schrieb Johan Jonker: > The Rk3066 hdmi output format is hard coded to RGB. Remove > all useless code related to colorimetry and enc_out_format. > > Signed-off-by: Johan Jonker I guess my first question is, is the hardcoding happening just because of missing functionality in the driver, or does the hardware only support RGB? > --- > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > index 0e7aae341960..f2b1b2faa096 100644 > --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c > +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > @@ -23,8 +23,6 @@ > > struct hdmi_data_info { > int vic; /* The CEA Video ID (VIC) of the current drm display mode. */ > - unsigned int enc_out_format; > - unsigned int colorimetry; > }; > > struct rk3066_hdmi_i2c { > @@ -200,14 +198,7 @@ static int rk3066_hdmi_config_avi(struct rk3066_hdmi *hdmi, > rc = drm_hdmi_avi_infoframe_from_display_mode(&frame.avi, > &hdmi->connector, mode); > > - if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV444) > - frame.avi.colorspace = HDMI_COLORSPACE_YUV444; > - else if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV422) > - frame.avi.colorspace = HDMI_COLORSPACE_YUV422; > - else > - frame.avi.colorspace = HDMI_COLORSPACE_RGB; > - > - frame.avi.colorimetry = hdmi->hdmi_data.colorimetry; > + frame.avi.colorspace = HDMI_COLORSPACE_RGB; > frame.avi.scan_mode = HDMI_SCAN_MODE_NONE; > > return rk3066_hdmi_upload_frame(hdmi, rc, &frame, > @@ -329,15 +320,6 @@ static int rk3066_hdmi_setup(struct rk3066_hdmi *hdmi, > struct drm_display_info *display = &hdmi->connector.display_info; > > hdmi->hdmi_data.vic = drm_match_cea_mode(mode); > - hdmi->hdmi_data.enc_out_format = HDMI_COLORSPACE_RGB; > - > - if (hdmi->hdmi_data.vic == 6 || hdmi->hdmi_data.vic == 7 || > - hdmi->hdmi_data.vic == 21 || hdmi->hdmi_data.vic == 22 || > - hdmi->hdmi_data.vic == 2 || hdmi->hdmi_data.vic == 3 || > - hdmi->hdmi_data.vic == 17 || hdmi->hdmi_data.vic == 18) > - hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_601; > - else > - hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_709; while I can understand the RGB output format, why does the colorimetry also get removed? This looks like it is dependent on the mode itself and not the output format? Thanks Heiko