From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH libata-dev-2.6:upstream 01/02] libata: implement ata_poll_qc_complete and use it in polling functions
Date: Sun, 21 Aug 2005 15:53:58 -0400 [thread overview]
Message-ID: <4308DBD6.80208@pobox.com> (raw)
In-Reply-To: <20050820141408.5788A466@htj.dyndns.org>
Tejun Heo wrote:
> 01_libata_add-ata_poll_qc_complete.patch
>
> Previously, libata polling functions turned irq back on and
> completed qc commands without holding host lock. This creates
> a race condition between the polling task and interrupts from
> other ports on the same host set or spurious interrupt from
> itself.
>
> This patch implements ata_poll_qc_complete which enables irq
> and completes qc atomically and convert all polling functions.
>
> Note: Unlike other functions, atapi_packet_task() didn't use
> to turn irq back on on error exits. This patch makes it use
> ata_poll_qc_complete, so irq is now turned back on on error
> exits.
>
> Note: With this change, ALL invocations of ata_qc_complete()
> are now done under host_set lock.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
This one looks OK to me. Given that I rejected the other three, would
you still like me to apply just this one?
Jeff
next prev parent reply other threads:[~2005-08-21 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-20 14:15 [PATCH libata-dev-2.6:upstream 00/02] libata: race fixes Tejun Heo
2005-08-20 14:15 ` [PATCH libata-dev-2.6:upstream 01/02] libata: implement ata_poll_qc_complete and use it in polling functions Tejun Heo
2005-08-21 19:53 ` Jeff Garzik [this message]
2005-08-22 8:12 ` Tejun Heo
2005-08-23 5:06 ` Jeff Garzik
2005-08-20 14:15 ` [PATCH libata-dev-2.6:upstream 02/02] libata: add host_set locking to ata_scsi_error() Tejun Heo
2005-08-21 19:52 ` Jeff Garzik
2005-08-22 8:23 ` Tejun Heo
2005-08-21 20:08 ` a word about ATA interrupts, and SATA (was Re: [PATCH libata-dev-2.6:upstream 00/02] libata: race fixes) Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4308DBD6.80208@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.