From: Marcus Hall <marcushall@lucent.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Patch for drivers/cfi_flash.c; properly detect write errors.
Date: Tue, 23 Aug 2005 15:01:53 -0600 [thread overview]
Message-ID: <430B8EC1.6090406@lucent.com> (raw)
Hello..
It seems that there is a minor problem in cfi_flash.c that prevents it
from detecting that a flash write error has occurred.
The first change in the attached patch is trivial, it just makes the
strings output for a protected and a non-protected sector have the same
length so the output looks prettier..
The second change is in flash_full_status_check(). We have just called
flash_status_check() and then did a switch() on the vendor. For intel,
we *should* check if there are any error bits if the previous call
returned ERR_OK (Otherwise we will have output an error message in
flash_status_check() already.) The original code would only check for
error bits if flash_status_check() returns ERR_TIMEOUT.
--
Marcus Hall
marcushall at lucent.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: CFI_FLASH.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050823/922fe166/attachment.txt
next reply other threads:[~2005-08-23 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 21:01 Marcus Hall [this message]
2006-02-28 16:36 ` [U-Boot-Users] Patch for drivers/cfi_flash.c; properly detect write errors Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430B8EC1.6090406@lucent.com \
--to=marcushall@lucent.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.