From: Nick Sillik <n.sillik@temple.edu>
To: Nick Sillik <n.sillik@temple.edu>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [-mm PATCH] drivers/char/speakup/synthlist.h - Fix warnings with -Wundef
Date: Wed, 24 Aug 2005 01:52:51 -0400 [thread overview]
Message-ID: <430C0B33.7000708@temple.edu> (raw)
In-Reply-To: <430C07F0.8010001@temple.edu>
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
Nick Sillik wrote:
> Alexey Dobriyan wrote:
>
>>
>>> -#define CFG_TEST(name) (name)
>>> +#define CFG_TEST(name) defined(name)
>>
>>
>>
>> No. Just remove this obfuscating macro.
>
>
> Agreed, here is the fixed patch
>
> Signed-Off-By: Nick Sillik <n.sillik@temple.edu>
No here it really is... (sorry)
Signed-Off-By: Nick Sillik <n.sillik@temple.edu>
[-- Attachment #2: speakup-wundef.patch --]
[-- Type: text/x-patch, Size: 1929 bytes --]
diff -urN -X linux-2.6.13-rc6-mm2/Documentation/dontdiff linux-2.6.13-rc6-mm2/drivers/char/speakup/synthlist.h linux-2.6.13-rc6-mm2-patched/drivers/char/speakup/synthlist.h
--- linux-2.6.13-rc6-mm2/drivers/char/speakup/synthlist.h 2005-08-24 01:37:59.000000000 -0400
+++ linux-2.6.13-rc6-mm2-patched/drivers/char/speakup/synthlist.h 2005-08-24 01:37:37.000000000 -0400
@@ -2,53 +2,51 @@
#if defined(PASS2)
/* table of built in synths */
#define SYNTH_DECL(who) &synth_##who,
-#define CFG_TEST(name) (name)
#else
/* declare extern built in synths */
#define SYNTH_DECL(who) extern struct spk_synth synth_##who;
#define PASS2
-#define CFG_TEST(name) (name)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_ACNTPC)
+#ifdef CONFIG_SPEAKUP_ACNTPC
SYNTH_DECL(acntpc)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_ACNTSA)
+#ifdef CONFIG_SPEAKUP_ACNTSA
SYNTH_DECL(acntsa)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_APOLLO)
+#ifdef CONFIG_SPEAKUP_APOLLO
SYNTH_DECL(apollo)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_AUDPTR)
+#ifdef CONFIG_SPEAKUP_AUDPTR
SYNTH_DECL(audptr)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_BNS)
+#ifdef CONFIG_SPEAKUP_BNS
SYNTH_DECL(bns)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_DECEXT)
+#ifdef CONFIG_SPEAKUP_DECEXT
SYNTH_DECL(decext)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_DECTLK)
+#ifdef CONFIG_SPEAKUP_DECTLK
SYNTH_DECL(dectlk)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_DTLK)
+#ifdef CONFIG_SPEAKUP_DTLK
SYNTH_DECL(dtlk)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_KEYPC)
+#ifdef CONFIG_SPEAKUP_KEYPC
SYNTH_DECL(keypc)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_LTLK)
+#ifdef CONFIG_SPEAKUP_LTLK
SYNTH_DECL(ltlk)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_SFTSYN)
+#ifdef CONFIG_SPEAKUP_SFTSYN
SYNTH_DECL(sftsyn)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_SPKOUT)
+#ifdef CONFIG_SPEAKUP_SPKOUT
SYNTH_DECL(spkout)
#endif
-#if CFG_TEST(CONFIG_SPEAKUP_TXPRT)
+#ifdef CONFIG_SPEAKUP_TXPRT
SYNTH_DECL(txprt)
#endif
#undef SYNTH_DECL
-#undef CFG_TEST
+#undef
next prev parent reply other threads:[~2005-08-24 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 20:00 [-mm PATCH] drivers/char/speakup/synthlist.h - Fix warnings with -Wundef Nick Sillik
2005-08-24 5:37 ` Alexey Dobriyan
2005-08-24 5:38 ` Nick Sillik
2005-08-24 5:52 ` Nick Sillik [this message]
2005-08-24 18:04 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430C0B33.7000708@temple.edu \
--to=n.sillik@temple.edu \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.