All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Priewasser <priewasser@gmail.com>
To: kyungmin.park@samsung.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] OneNAND: Simple Bad Block handling support
Date: Thu, 25 Aug 2005 09:56:26 +0200	[thread overview]
Message-ID: <430D79AA.2050105@gmail.com> (raw)
In-Reply-To: <0ILR00B812WSF3@mmp1.samsung.com>

Alright.

1) You could update your mtd sources and diff again, OR
simply replace BBM patch's line 23 "return -EAGAIN" with "return -EIO".

2) In syncread-patch you add "void (*mmcontrol)" on line 103 of 
include/linux/onenand.h.
BBM patch is looking for this "void (*mmcontrol)" to add some new stuff 
here. E.g. it doesn't search the "original" onenand.h (official MTD) but 
the already syncread-patched onenand.h, bbm-patch cannot be run before 
sync-patch was run.
No problem at all if one know's all this :-) Perhaps it would be good to 
change the  struct onenand_chip declaration order in a way that both 
patches can be run independent of each other. Until they are put to MTD 
CVS anyway...

-> THE RULES:
+ Run all the patches inside the kernel tree
+ Be aware of the right order:
   1. onenand-syncread.patch
   2. onenand-bbm.patch
   3. omap-onenand.patch

Regards,
Bernhard

  reply	other threads:[~2005-08-25  7:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-18  8:16 [PATCH] OneNAND: Simple Bad Block handling support Kyungmin Park
2005-08-23 13:56 ` Bernhard Priewasser
2005-08-23 23:42   ` Kyungmin Park
2005-08-24  9:24     ` Bernhard Priewasser
2005-08-24 10:49     ` Bernhard Priewasser
2005-08-24 23:36       ` Kyungmin Park
2005-08-25  7:56         ` Bernhard Priewasser [this message]
2005-09-01  9:30         ` Bernhard Priewasser
2005-09-01 10:03           ` Kyungmin Park
2005-09-01 10:09             ` Bernhard Priewasser
2005-09-07  8:09             ` Bernhard Priewasser
2005-09-07 11:44               ` Kyungmin Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=430D79AA.2050105@gmail.com \
    --to=priewasser@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.