From: Brian King <brking@us.ibm.com>
To: Sonny Rao <sonnyrao@us.ibm.com>
Cc: cmm@us.ibm.com, wmb@us.ibm.com, slpratt@us.ibm.com,
greg@kroah.com, linux-fsdevel@vger.kernel.org
Subject: Re: IPR driver performance issue
Date: Thu, 25 Aug 2005 15:11:03 +0100 [thread overview]
Message-ID: <430DD177.3080208@us.ibm.com> (raw)
In-Reply-To: <20050825022411.GA6057@localhost.localdomain>
I think this is a libsysfs/iprutils issue due to a sysfs change in
recent kernels. Install sysfsutils 1.3.0, then grab the latest iprutils
package from
http://prdownloads.sourceforge.net/iprdd/iprutils-2.0.15.4-1.src.rpm?download.
Rebuild against libsysfs 1.3 with --target=ppc and upgrade the package.
Restart the following iprutils init.d services: iprinit, iprupdate,
iprdump and re-run your test.
Brian
Sonny Rao wrote:
> Hi Brian,
>
> I recently noticed a severe regression on certain
> filesystems for a simple dd create test. The odd thing was that
> filesystems which implemented the "writepages" aop along with
> "writepage" aop (which all writable filesystems implement) didn't seem
> to suffer nearly as much. So, I was thinking that maybe TCQ or
> something isn't quite working correctly.
>
> I have tried the same file creation test on non-local fibre storage
> and don't see the degredation there, and we don't see it on x86 or
> x86-64 either.
>
> I noticed the problem in 2.6.13-rc6 but I tracked it down to a patch
> that went into 2.6.12-rc5 which looks fairly benign. It was a merge
> from Greg-KH's device driver tree into mainline:
>
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=05d3794aa8bd3b2c9f7920a05003c331cdeb75c5
>
> I have confirmed on multiple IPR machines that if I revert this patch
> from 2.6.12-rc5, I see huge ( over 2x in some cases) improvements in
> the dd file create test on the affected filesystems.
>
> Do you have any idea why this would happen?
>
> The only suspicious looking part to me is this one from
> drivers/base/core.c
>
> @@ -89,7 +87,6 @@ static void device_release(struct kobjec
> static struct kobj_type ktype_device = {
> .release = device_release,
> .sysfs_ops = &dev_sysfs_ops,
> - .default_attrs = dev_default_attrs,
> };
>
> But I really have no idea what is going on
>
> I've attached the script I was using for the tests, the filesystems
> which regress are ext3, xfs, and reiserfs. Just edit the variables at
> the top for block device and mount-point for whatever machine you want
> to run on.
>
> Thanks,
>
> Sonny Rao
next parent reply other threads:[~2005-08-25 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050825022411.GA6057@localhost.localdomain>
2005-08-25 14:11 ` Brian King [this message]
[not found] ` <20050825153549.GA17403@localhost.localdomain>
2005-08-25 15:43 ` IPR driver performance issue Brian King
2005-08-28 22:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430DD177.3080208@us.ibm.com \
--to=brking@us.ibm.com \
--cc=cmm@us.ibm.com \
--cc=greg@kroah.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slpratt@us.ibm.com \
--cc=sonnyrao@us.ibm.com \
--cc=wmb@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.