From: Jeff Garzik <jgarzik@pobox.com>
To: dougg@torque.net, Jens Axboe <axboe@suse.de>
Cc: linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: error processing + rw 6 byte fix
Date: Sat, 27 Aug 2005 04:20:54 -0400 [thread overview]
Message-ID: <43102266.7040001@pobox.com> (raw)
In-Reply-To: <430FF537.7010705@torque.net>
[-- Attachment #1: Type: text/plain, Size: 47 bytes --]
Here is the patch I just checked in.
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 871 bytes --]
diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c
--- a/drivers/scsi/libata-scsi.c
+++ b/drivers/scsi/libata-scsi.c
@@ -630,11 +630,19 @@ static unsigned int ata_scsi_rw_xlat(str
tf->lbah = scsicmd[3];
VPRINTK("ten-byte command\n");
+ if (qc->nsect == 0) /* we don't support length==0 cmds */
+ return 1;
return 0;
}
if (scsicmd[0] == READ_6 || scsicmd[0] == WRITE_6) {
qc->nsect = tf->nsect = scsicmd[4];
+ if (!qc->nsect) {
+ qc->nsect = 256;
+ if (lba48)
+ tf->hob_nsect = 1;
+ }
+
tf->lbal = scsicmd[3];
tf->lbam = scsicmd[2];
tf->lbah = scsicmd[1] & 0x1f; /* mask out reserved bits */
@@ -674,6 +682,8 @@ static unsigned int ata_scsi_rw_xlat(str
tf->lbah = scsicmd[7];
VPRINTK("sixteen-byte command\n");
+ if (qc->nsect == 0) /* we don't support length==0 cmds */
+ return 1;
return 0;
}
next prev parent reply other threads:[~2005-08-27 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-22 9:02 [PATCH] libata: error processing + rw 6 byte fix Douglas Gilbert
2005-08-22 19:10 ` Jeff Garzik
2005-08-23 12:14 ` Douglas Gilbert
2005-08-27 3:31 ` Jeff Garzik
2005-08-23 7:13 ` Jens Axboe
2005-08-23 12:33 ` Douglas Gilbert
2005-08-23 12:44 ` Jens Axboe
2005-08-27 3:26 ` Jeff Garzik
2005-08-27 5:08 ` Douglas Gilbert
2005-08-27 7:17 ` Jens Axboe
2005-08-27 8:20 ` Jeff Garzik [this message]
2005-08-27 10:01 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43102266.7040001@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=dougg@torque.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.