From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 12/15] ether: extract function
	eth_dev_get_intr_handle
Date: Thu, 15 Sep 2016 16:05:54 +0200
Message-ID: <4310538.hvdbegMmPc@xps13>
References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com>
 <1473410639-10367-13-git-send-email-shreyansh.jain@nxp.com>
 <1378dc00-7fa7-6679-1118-5992cfd1adfd@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, viktorin@rehivetech.com, hemant.agrawal@nxp.com
To: "Hunt, David" <david.hunt@intel.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com
 [209.85.215.54]) by dpdk.org (Postfix) with ESMTP id 151F3569F
 for <dev@dpdk.org>; Thu, 15 Sep 2016 16:05:58 +0200 (CEST)
Received: by mail-lf0-f54.google.com with SMTP id u14so38365358lfd.1
 for <dev@dpdk.org>; Thu, 15 Sep 2016 07:05:58 -0700 (PDT)
In-Reply-To: <1378dc00-7fa7-6679-1118-5992cfd1adfd@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-09-15 14:02, Hunt, David:
> On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> > +static inline
> > +struct rte_intr_handle *eth_dev_get_intr_handle(struct rte_eth_dev *dev)
> > +{
> > +	if (dev->pci_dev) {
> > +		return &dev->pci_dev->intr_handle;
> > +	}
> > +
> > +	RTE_VERIFY(0);
> 
> Rather than RTE_VERIFY(0), might I suggest using rte_panic with a more 
> relevant error message?

RTE_ASSERT is preferred.
We must stop adding some rte_panic calls except for debug.