From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Tejun Heo <htejun@gmail.com>,
James.Bottomley@steeleye.com, luben_tuikov@adaptec.com,
albertcc@tw.ibm.com, linux-scsi@vger.kernel.org
Subject: Re: [RFC] SCSI EH document
Date: Mon, 29 Aug 2005 15:49:41 -0400 [thread overview]
Message-ID: <431366D5.5040605@pobox.com> (raw)
In-Reply-To: <20050829194954.GH26314@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox wrote:
> On Mon, Aug 29, 2005 at 02:50:35PM -0400, Jeff Garzik wrote:
>
>>Every node is a list_head. You want all pointers for all nodes pointing
>>to something useful, even if they are not actively present on a list, so
>>that they may be easily and corrected added to a list at a later time.
>>Read list_del_init() for example.
>
>
> I disagree. If you know what you're doing, it's perfectly fine to
> simply list_del and not init the nodes.
True, but in the context of $thread its better to be safe than sorry.
Jeff
next prev parent reply other threads:[~2005-08-29 19:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-26 3:53 [RFC] SCSI EH document Tejun Heo
2005-08-26 21:34 ` Jeff Garzik
2005-08-29 9:14 ` Tejun Heo
2005-08-29 13:55 ` Luben Tuikov
2005-08-30 10:47 ` Tejun Heo
2005-08-30 14:50 ` Luben Tuikov
2005-08-29 18:50 ` Jeff Garzik
2005-08-29 19:49 ` Matthew Wilcox
2005-08-29 19:49 ` Jeff Garzik [this message]
2005-08-29 21:38 ` Tejun Heo
2005-08-29 22:27 ` Jeff Garzik
2005-08-26 21:36 ` Luben Tuikov
2005-09-07 8:04 ` Jeff Garzik
2005-09-07 11:22 ` Tejun Heo
2005-09-07 13:12 ` Luben Tuikov
2005-09-07 14:00 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431366D5.5040605@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@steeleye.com \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.