From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Subject: Re: [PATCH 3/3] CLUSTERIP: use a bitmap to store node responsibility data Date: Tue, 30 Aug 2005 17:18:59 +0200 Message-ID: <431478E3.7050106@netfilter.org> References: <20050830121535.985929000@nienna.balabit> <20050830121550.543376000@nienna.balabit> <43145F3B.4050706@netfilter.org> <200508301534.32353@nienna> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Harald Welte , netfilter-devel@lists.netfilter.org Return-path: To: KOVACS Krisztian In-Reply-To: <200508301534.32353@nienna> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org KOVACS Krisztian wrote: > On Tuesday 30 August 2005 15.29, Pablo Neira wrote: > >>KOVACS Krisztian wrote: >> >>>@@ -55,8 +56,7 @@ >>> u_int8_t clustermac[ETH_ALEN]; /* the MAC address */ >>> struct net_device *dev; /* device */ >>> u_int16_t num_total_nodes; /* total number of nodes */ >>>- u_int16_t num_local_nodes; /* number of local nodes */ >>>- u_int16_t local_nodes[CLUSTERIP_MAX_NODES]; /* node number array >>>*/ + unsigned long local_nodes; /* node number array */ >> >>I'm afraid that this breaks backward compatibility. Although >>CLUSTERIP is marked as experimental. > > > IMHO this does not break compatibility, since this change only affects > the internal clusterip_config structure, not the target info structure > itself. (And the module does conversion in checkentry().) You're right, sorry for the noise. -- Pablo