From: Anthony Liguori <aliguori@us.ibm.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] Fix buffer overflow in xenconsoled
Date: Tue, 30 Aug 2005 16:57:16 -0500 [thread overview]
Message-ID: <4314D63C.7020700@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
Appears to be a typo.
Christian's watch changes threw me off a bit as I had been pursuing
another route to fix the same problems. This bug is still valid though.
Regards,
Anthony Liguori
Signed-off-by: Anthony Liguori
[-- Attachment #2: 6483_consoled.diff --]
[-- Type: text/x-patch, Size: 671 bytes --]
# HG changeset patch
# User Anthony Liguori <aliguori@us.ibm.com>
# Node ID 444e4fa43bf1123873cddecff51d9fe593271eae
# Parent fe6c5ecea53aabedc6b53988da25910e108eafe9
Fix overflow in reading from console
diff -r fe6c5ecea53a -r 444e4fa43bf1 tools/console/daemon/io.c
--- a/tools/console/daemon/io.c Tue Aug 30 22:01:01 2005
+++ b/tools/console/daemon/io.c Tue Aug 30 22:05:28 2005
@@ -353,7 +353,7 @@
(struct ring_head *)(dom->page + PAGE_SIZE/2);
int i;
- len = read(dom->tty_fd, msg, MAX(XENCONS_SPACE(inring), sizeof(msg)));
+ len = read(dom->tty_fd, msg, MIN(XENCONS_SPACE(inring), sizeof(msg)));
if (len < 1) {
close(dom->tty_fd);
dom->tty_fd = -1;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2005-08-30 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 21:57 Anthony Liguori [this message]
2005-08-31 8:44 ` [PATCH] Fix buffer overflow in xenconsoled Christian Limpach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4314D63C.7020700@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.