From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: add ATAPI module option
Date: Tue, 30 Aug 2005 19:54:48 -0400 [thread overview]
Message-ID: <4314F1C8.8040706@rtr.ca> (raw)
In-Reply-To: <20050830215234.GA6991@havoc.gtf.org>
Jeff Garzik wrote:
>
> -#ifndef ATA_ENABLE_ATAPI
> - if (unlikely(dev->class == ATA_DEV_ATAPI))
> - return NULL;
> -#endif
> + if (atapi_enabled) {
> + if (unlikely(dev->class == ATA_DEV_ATAPI))
> + return NULL;
> + }
..
Is that if-stmt the right way around?
At first glance, I'd expect it to read:
if (!atapi_enabled) {
...
Cheers!
next prev parent reply other threads:[~2005-08-30 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 21:52 [PATCH] libata: add ATAPI module option Jeff Garzik
2005-08-30 23:54 ` Mark Lord [this message]
2005-08-31 1:52 ` Jeff Garzik
2005-10-22 3:25 ` Mark Lord
2005-10-22 3:34 ` Jeff Garzik
2005-10-22 4:00 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4314F1C8.8040706@rtr.ca \
--to=liml@rtr.ca \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.