From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: Build breakage in vtpm (missing dependency on libgpm)
Date: Thu, 01 Sep 2005 10:17:26 -0500
Message-ID: <43171B86.6040303@us.ibm.com>
References: <E1EAg6W-00028K-00@mta1.cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <E1EAg6W-00028K-00@mta1.cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Steven Hand <Steven.Hand@cl.cam.ac.uk>
Cc: Dan Smith <danms@us.ibm.com>, xen-devel <xen-devel@lists.xensource.com>, Stefan Berger <stefanb@us.ibm.com>
List-Id: xen-devel@lists.xenproject.org

Steven Hand wrote:

>>I'd prefer that we only build vtpm if libgpm is present.  In the very 
>>least, we should add a check for it if we always want to build it.
>>
>>    
>>
>
>Certainly - can you knock up a patch?
>  
>
Looks like Keir beat me to it (I swear he's a machine :-)).

>[note - the vtpm stuff needs more testing, particularly with save/restore; 
>if someone is running w/out netgrants it'd be good if they could confirm
>it doesn't break save/restore for them] 
>  
>
Dan Smith has been working on a regression suite for xm.  It might make 
sense to look into adding some TPM tests to it.

Regards,

Anthony Liguori

>cheers,
>
>S.
>
>  
>