From: Jiri Slaby <jirislaby@gmail.com>
To: Ben Dooks <ben@fluff.org.uk>
Cc: Alon Bar-Lev <alon.barlev@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Serial driver (serial_core.c) status messages should be set to KERN_INFO
Date: Thu, 01 Sep 2005 23:04:04 +0200 [thread overview]
Message-ID: <43176CC4.7040105@gmail.com> (raw)
In-Reply-To: <20050901204610.GA1816@home.fluff.org>
Ben Dooks napsal(a):
>On Thu, Sep 01, 2005 at 10:38:26PM +0200, Jiri Slaby wrote:
>
>
>>Alon Bar-Lev napsal(a):
>>
>>
>>>static inline void
>>>
>>>uart_report_port(struct uart_driver *drv, struct uart_port *port)
>>>{
>>>- printk("%s%d", drv->dev_name, port->line);
>>>+ printk(KERN_INFO + "%s%d", drv->dev_name, port->line);
>>>
>>>
>>plus sign between that?
>>
>>
>>
>>> printk(" at ");
>>>
>>>
>>why the fellows didn't put this to the line above?
>>
>>
>>> switch (port->iotype) {
>>> case UPIO_PORT:
>>> printk("I/O 0x%x", port->iobase);
>>>
>>>
>>And what about these?
>>
>>
>
>looks like they're not on a newline, so need no severity.
>
>
ok, ok, but isn't this a little bit racy (so you can see dev_name and
line, then another driver's info and then " at ", then something else...)
regards,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
next prev parent reply other threads:[~2005-09-01 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 21:26 Serial driver (serial_core.c) status messages should be set to KERN_INFO Alon Bar-Lev
2005-09-01 20:38 ` Jiri Slaby
2005-09-01 20:46 ` Ben Dooks
2005-09-01 21:04 ` Jiri Slaby [this message]
2005-09-01 21:38 ` Russell King
2005-09-01 21:49 ` Alon Bar-Lev
2005-09-02 15:21 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43176CC4.7040105@gmail.com \
--to=jirislaby@gmail.com \
--cc=alon.barlev@gmail.com \
--cc=ben@fluff.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.