From: Corey Minyard <minyard@acm.org>
To: Andrew Morton <akpm@osdl.org>
Cc: viro@ZenIV.linux.org.uk, Matt_Domsch@Dell.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][CFLART] ipmi procfs bogosity
Date: Thu, 01 Sep 2005 18:03:54 -0500 [thread overview]
Message-ID: <431788DA.3010801@acm.org> (raw)
In-Reply-To: <20050901124114.7af633b1.akpm@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
Andrew Morton wrote:
>Corey Minyard <minyard@acm.org> wrote:
>
>
>>Indeed, this function is badly written. In rewriting, I couldn't find a
>> nice function for reading integers from userspace, and the proc_dointvec
>> stuff didn't seem terribly suitable.
>>
>>
>
>We write numbers into profs files all the time. Is there something
>different about the IPMI requirement which makes the approach used by, say,
>dirty_writeback_centisecs_handler() inappropriate?
>
>
Ok, that's probably better, and this probably belongs in
/proc/sys/dev/ipmi. This is new enough that it doesn't matter, I don't
think any one is using it yet.
Patch is attached.
-Corey
[-- Attachment #2: ipmi-poweroff-fix-chassis-ctrl.patch --]
[-- Type: unknown/unknown, Size: 8332 bytes --]
prev parent reply other threads:[~2005-09-01 23:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 6:43 [RFC][CFLART] ipmi procfs bogosity viro
2005-09-01 16:41 ` Corey Minyard
2005-09-01 19:32 ` viro
2005-09-01 20:00 ` Corey Minyard
2005-09-01 20:30 ` Alexey Dobriyan
2005-09-05 10:51 ` Ingo Oeser
2005-09-05 19:38 ` Alexey Dobriyan
2005-09-01 19:41 ` Andrew Morton
2005-09-01 23:03 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431788DA.3010801@acm.org \
--to=minyard@acm.org \
--cc=Matt_Domsch@Dell.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.