From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <431A810B.2060705@xmission.com> From: Brad Midgley MIME-Version: 1.0 To: BlueZ Mailing List Content-Type: text/plain; charset=us-ascii; format=flowed Subject: [Bluez-devel] sbc synthesis inconsistencies Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Sat, 03 Sep 2005 23:07:23 -0600 Guys, Have any of you looked closely at this? It comes straight from the spec for a2dp on page 66: /* Build a 80 values vector U */ for (i = 0; i <= 4; i++) { for (j = 0; j < 8; j++) { state->U[ch][i * 16 + j] = state->V[ch][i * 32 + j]; state->U[ch][i * 16 + j + 8] = state->V[ch][i * 32 + j + 24]; } } But isn't this code only populating u[ch][0..63] and not through 79 like the comment suggests? So the u[ch][64..79] terms are always 0 right? This isn't the only thing that looks wrong in the spec. We also have a sliding window of v[] values that moves 16 values in each pass. The vector is 160 elements long even though the code above never accesses anything beyond the 128th value! It's amazing this stuff even works as poorly specified as it is :( BTW, in our code it looks like sbc_synthesize_eight was multiplying sbc_proto_8_80 by -4 where it should be -8. I changed that in cvs. Brad ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel